Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: fix waiting for disabled button in some tests #49

Merged

Conversation

rvykydal
Copy link
Contributor

The rhinstaller/anaconda#5327 migrated to this new repository.

@rvykydal
Copy link
Contributor Author

Regarding the rhinstaller/anaconda#5327 (comment)

I was just confused by the double negation.

Can you please iron it out a bit:

b.wait_visible(f"#installation-back-btn[aria-disabled=true]")

I was thinking there must be a reason why I didn't do it and it is that it just did not work for me (as checked now).

@KKoukiou KKoukiou force-pushed the webui-fix-checking-disabled-button branch from 85a1dc2 to fe0bfd0 Compare November 20, 2023 14:05
@rvykydal
Copy link
Contributor Author

@KKoukiou thank you for re-checking, I didn't apply your suggestion correctly locally.

@KKoukiou KKoukiou merged commit 2555cdb into rhinstaller:main Nov 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants