Changing Node interface and updating NMC controller #1220
Merged
+81
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for openshift-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/assign @ybettan |
|
Fixes 1219 |
|
/test check-api-changes |
|
/test e2e |
|
/test e2e-hub |
|
/test operator-upgrade |
|
/test e2e |
|
ci/prow/e2e-hub |
|
/test e2e-hub |
|
/test operator-upgrade |
mresvanis
reviewed
Sep 25, 2024
| @@ -1356,16 +1315,16 @@ var _ = Describe("nmcReconcilerHelperImpl_RecordEvents", func() { | |||
| var ( | |||
| client *testclient.MockClient | |||
| fakeRecorder *record.FakeRecorder | |||
| n node.Node | |||
| wh nmcReconcilerHelper | |||
| //nm *node.MockNode | |||
There was a problem hiding this comment.
Suggested change
| //nm *node.MockNode |
mresvanis
reviewed
Sep 25, 2024
| ) | ||
|
|
||
| BeforeEach(func() { | ||
| ctrl := gomock.NewController(GinkgoT()) | ||
| client = testclient.NewMockClient(ctrl) | ||
| n = node.NewNode(client) | ||
| //nm = node.NewMockNode(ctrl) |
There was a problem hiding this comment.
Suggested change
| //nm = node.NewMockNode(ctrl) |
This PR is a preparation for the fixes needed for cluster upgrade KMM implementation. We are adding a new function to the node interface, that determines whether a node has been rebooted while a kernel module was loaded. This PR also updates NMC controller to use this API and refactors the unit-test
yevgeny-shnaidman
force-pushed
the
yevgeny/cherry-pick-397672464d06ec9f131fea080e6034d6e315ce37
branch
from
6a736c4
to
72c6040
Compare
|
/lgtm |
openshift-merge-bot
bot
merged commit aed4d51
into
rh-ecosystem-edge:main
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a preparation for the fixes needed for cluster upgrade KMM implementation. We are adding a new function to the node interface, that determines whether a node has been rebooted while a kernel module was loaded. This PR also updates NMC controller to use this API and refactors the unit-test