Upgrade svelte-check, svelte2tsx

rgossiaux · Jul 11, 2023 · 888b4b3 · 888b4b3 · vercel · Jul 11, 2023
1 parent 4eb752c
commit 888b4b3
Show file tree

Hide file tree

Showing 13 changed files with 214 additions and 114 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -60,12 +60,12 @@
     "rehype-autolink-headings": "^6.1.1",
     "rehype-slug": "^5.0.1",
     "svelte": "^3.47.0",
-    "svelte-check": "^2.4.1",
+    "svelte-check": "^3.4.3",
     "svelte-inline-compile": "^0.0.1",
     "svelte-jester": "^2.1.5",
     "svelte-popperjs": "^1.2.7",
     "svelte-preprocess": "^4.9.8",
-    "svelte2tsx": "^0.5.0",
+    "svelte2tsx": "^0.6.15",
     "tailwindcss": "^3.0.0",
     "ts-jest": "^27.1.2",
     "tslib": "^2.3.1",

diff --git a/src/lib/components/listbox/Listbox.svelte b/src/lib/components/listbox/Listbox.svelte
@@ -60,7 +60,7 @@
     /** Whether the entire `Listbox` should be oriented horizontally instead of vertically */
     horizontal?: boolean;
     /** The selected value */
-    value?: StateDefinition["value"];
+    value: StateDefinition["value"];
   };
 </script>
 

diff --git a/src/lib/components/listbox/ListboxOption.svelte b/src/lib/components/listbox/ListboxOption.svelte
@@ -1,8 +1,9 @@
 <script lang="ts" context="module">
+  // The HTML typings include `value` so we must ignore it
   type TListboxOptionProps<
     TSlotProps extends {},
     TAsProp extends SupportedAs
-  > = TPassThroughProps<TSlotProps, TAsProp, "li"> & {
+  > = Omit<TPassThroughProps<TSlotProps, TAsProp, "li">, "value"> & {
     /** The option value */
     value: unknown;
     /** Whether the option should be disabled for keyboard navigation and ARIA purposes */

diff --git a/src/lib/hooks/use-inert-others.ts b/src/lib/hooks/use-inert-others.ts
@@ -6,7 +6,6 @@ let originals = new Map<
 
 function inert(element: HTMLElement) {
   element.setAttribute("aria-hidden", "true");
-  // @ts-expect-error `inert` does not exist on HTMLElement (yet!)
   element.inert = true;
 }
 
@@ -16,7 +15,6 @@ function restore(element: HTMLElement) {
 
   if (original["aria-hidden"] === null) element.removeAttribute("aria-hidden");
   else element.setAttribute("aria-hidden", original["aria-hidden"]);
-  // @ts-expect-error `inert` does not exist on HTMLElement (yet!)
   element.inert = original.inert;
 }
 
@@ -53,7 +51,6 @@ export function useInertOthers<TElement extends HTMLElement>(
     if (interactables.size === 1) {
       originals.set(child, {
         "aria-hidden": child.getAttribute("aria-hidden"),
-        // @ts-expect-error `inert` does not exist on HTMLElement (yet!)
         inert: child.inert,
       });
 
@@ -83,7 +80,6 @@ export function useInertOthers<TElement extends HTMLElement>(
 
         originals.set(child, {
           "aria-hidden": child.getAttribute("aria-hidden"),
-          // @ts-expect-error `inert` does not exist on HTMLElement (yet!)
           inert: child.inert,
         });
 

diff --git a/src/routes/docs/1.0/examples/_PopoverIconOne.svelte b/src/routes/docs/1.0/examples/_PopoverIconOne.svelte
@@ -4,6 +4,7 @@
   viewBox="0 0 48 48"
   fill="none"
   xmlns="http://www.w3.org/2000/svg"
+  {...$$props}
 >
   <rect width="48" height="48" rx="8" fill="#FFEDD5" />
   <path

diff --git a/src/routes/docs/1.0/examples/_PopoverIconThree.svelte b/src/routes/docs/1.0/examples/_PopoverIconThree.svelte
@@ -4,6 +4,7 @@
   viewBox="0 0 48 48"
   fill="none"
   xmlns="http://www.w3.org/2000/svg"
+  {...$$props}
 >
   <rect width="48" height="48" rx="8" fill="#FFEDD5" />
   <rect x="13" y="32" width="2" height="4" fill="#FDBA74" />

diff --git a/src/routes/docs/1.0/examples/_PopoverIconTwo.svelte b/src/routes/docs/1.0/examples/_PopoverIconTwo.svelte
@@ -4,6 +4,7 @@
   viewBox="0 0 48 48"
   fill="none"
   xmlns="http://www.w3.org/2000/svg"
+  {...$$props}
 >
   <rect width="48" height="48" rx="8" fill="#FFEDD5" />
   <path

diff --git a/src/routes/docs/2.0/examples/_PopoverIconOne.svelte b/src/routes/docs/2.0/examples/_PopoverIconOne.svelte
@@ -4,6 +4,7 @@
   viewBox="0 0 48 48"
   fill="none"
   xmlns="http://www.w3.org/2000/svg"
+  {...$$props}
 >
   <rect width="48" height="48" rx="8" fill="#FFEDD5" />
   <path

diff --git a/src/routes/docs/2.0/examples/_PopoverIconThree.svelte b/src/routes/docs/2.0/examples/_PopoverIconThree.svelte
@@ -4,6 +4,7 @@
   viewBox="0 0 48 48"
   fill="none"
   xmlns="http://www.w3.org/2000/svg"
+  {...$$props}
 >
   <rect width="48" height="48" rx="8" fill="#FFEDD5" />
   <rect x="13" y="32" width="2" height="4" fill="#FDBA74" />

diff --git a/src/routes/docs/2.0/examples/_PopoverIconTwo.svelte b/src/routes/docs/2.0/examples/_PopoverIconTwo.svelte
@@ -4,6 +4,7 @@
   viewBox="0 0 48 48"
   fill="none"
   xmlns="http://www.w3.org/2000/svg"
+  {...$$props}
 >
   <rect width="48" height="48" rx="8" fill="#FFEDD5" />
   <path

diff --git a/src/routes/popover/_Button.svelte b/src/routes/popover/_Button.svelte
@@ -4,7 +4,7 @@
 
 <PopoverButton
   class="px-3 py-2 bg-gray-300 border-2 border-transparent focus:outline-none focus:border-blue-900"
-  {...$$restProps}
+  {...$$props}
 >
   <slot />
 </PopoverButton>
diff --git a/src/routes/popover/_Link.svelte b/src/routes/popover/_Link.svelte
@@ -1,7 +1,7 @@
 <a
   href="/"
   class="px-3 py-2 border-2 border-transparent hover:bg-gray-200 focus:bg-gray-200 focus:outline-none focus:border-blue-900"
-  {...$$restProps}
+  {...$$props}
 >
   <slot />
 </a>