Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No superc #4

Merged
merged 3 commits into from
Mar 25, 2015
Merged

No superc #4

merged 3 commits into from
Mar 25, 2015

Conversation

keith-turner
Copy link
Member

No description provided.

// TODO check generic type parameters

Field[] fields = clazz.getDeclaredFields();
Field[] fields = clazz.getFields();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about protected fields? Don't we care about those?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn it, I thought this method would return those. It does not. Not seeing an easy way to get inherited protected methods. Would have to recurse up. When recursing up, would need to dedupe taking 1st (handle case where subclass overrides superclass protected method and changes return type).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added partial support for protected methods. Thinking we can open an issue to cover protected methods in super classes. Really need test for tricky cases like this. I think it would be better to refactor the code to make it easier to test and then add support for protected in superclass with test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #6

@ctubbsii ctubbsii merged commit 86df79e into revelc:master Mar 25, 2015
@ctubbsii ctubbsii added this to the 1.0.0 milestone Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants