Favour pure NTLM provider and fix SPN #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides actual values for the SPN target name on the NTLM payloads. Also favours the pure NTLM provider in the spnego library if a username and password are provided. This is done for backwards compatibility with older releases of this library which didn't use SSPI.
Kokogram72
approved these changes
Jun 5, 2024
github-merge-queue bot
referenced
this pull request
in chezmoi-sh/atlas
Jun 10, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | OpenSSF | |---|---|---|---| | [requests-ntlm](https://togithub.com/requests/requests-ntlm) | minor | `==1.2.0` -> `==1.3.0` | [](https://securityscorecards.dev/viewer/?uri=github.com/requests/requests-ntlm) | --- ### Release Notes <details> <summary>requests/requests-ntlm (requests-ntlm)</summary> ### [`v1.3.0`](https://togithub.com/requests/requests-ntlm/releases/tag/v1.3.0) [Compare Source](https://togithub.com/requests/requests-ntlm/compare/v1.2.0...v1.3.0) #### What's Changed - Fix type annotation problem by setting correct pyspnego min version by [@​jborean93](https://togithub.com/jborean93) in [https://github.com/requests/requests-ntlm/pull/135](https://togithub.com/requests/requests-ntlm/pull/135) - Throw an exception in case of access denied by [@​AdrianVollmer](https://togithub.com/AdrianVollmer) in [https://github.com/requests/requests-ntlm/pull/138](https://togithub.com/requests/requests-ntlm/pull/138) - Favour pure NTLM provider and fix SPN by [@​jborean93](https://togithub.com/jborean93) in [https://github.com/requests/requests-ntlm/pull/137](https://togithub.com/requests/requests-ntlm/pull/137) - Add type annotation and black/isort checks by [@​jborean93](https://togithub.com/jborean93) in [https://github.com/requests/requests-ntlm/pull/140](https://togithub.com/requests/requests-ntlm/pull/140) - Update CI and version and ignore black diff by [@​jborean93](https://togithub.com/jborean93) in [https://github.com/requests/requests-ntlm/pull/141](https://togithub.com/requests/requests-ntlm/pull/141) #### New Contributors - [@​AdrianVollmer](https://togithub.com/AdrianVollmer) made their first contribution in [https://github.com/requests/requests-ntlm/pull/138](https://togithub.com/requests/requests-ntlm/pull/138) **Full Changelog**: requests/requests-ntlm@v1.2.0...v1.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/chezmoi-sh/atlas). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides actual values for the SPN target name on the NTLM payloads. Also favours the pure NTLM provider in the spnego library if a username and password are provided. This is done for backwards compatibility with older releases of this library which didn't use SSPI.
Fixes: #136