Make rebuilds without code changes take less time #1086
+25
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toshok
commented
Jan 22, 2024
| @@ -120,6 +115,11 @@ fs.writeFileSync( | |||
| ` | |||
| ); | |||
|
|
|||
| if (currentPlatform() == "macOS" && drived_h_changed) { | |||
| // Make sure the main executable gets rebuilt with the new build ID. | |||
There was a problem hiding this comment.
shouldn't normal ninja deps ensure this already?
There was a problem hiding this comment.
I'm not sure, I don't remember adding this part 😬
jazzdan
approved these changes
Jan 22, 2024
| @@ -120,6 +115,11 @@ fs.writeFileSync( | |||
| ` | |||
| ); | |||
|
|
|||
| if (currentPlatform() == "macOS" && drived_h_changed) { | |||
| // Make sure the main executable gets rebuilt with the new build ID. | |||
There was a problem hiding this comment.
I'm not sure, I don't remember adding this part 😬
|
Nice! |
…them if they've changed. drops local mac arm build (on no local change, with no driver change) from 45s to 15s
toshok
force-pushed
the
toshok/make-rebuilds-quicker
branch
from
e8332bb
to
c7ea6e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.jsis unconditionally writing/touching source files, which results in some unnecessary recompilation locally. instead let's compare old/new contents and only write if we need to/touch if things have changed.Drops the rebuild time (with no code changes) from ~45s to ~15s on my m2 mbp.
probably something best done via buck longer term, but this felt like a pretty easy change.