Persist auth and refresh tokens #1072
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commit of the following: commit 994bdc9bd36d870958e6bd8e213c6905a6038dca Author: Chris Toshok <[email protected]> Date: Wed Dec 13 12:52:12 2023 -0800 remove the include too commit 3e82c721ce9bc805298538f6c1c3c56eb8a004b0 Author: Chris Toshok <[email protected]> Date: Wed Dec 13 12:08:38 2023 -0800 the big renaming commit bd81a6c7578e61771240a8fa7b3c7672973f9d68 Author: Chris Toshok <[email protected]> Date: Wed Dec 13 10:08:04 2023 -0800 rename the member fields, and switch to checking if the observer receiver is already bound (saving us that weird extra auth_token_store_ check) in RecordReplayRegisterAuthTokenObserver) commit 7f8369014d39183acc4efca9220dafcd51912f82 Author: Chris Toshok <[email protected]> Date: Fri Dec 8 11:23:30 2023 -0800 plumb the rest of the devtools messages to the (increasingly misnamed) auth token store
The GH polling we're doing is tying up a buildkite agent, causing everything to wait unnecessarily. We'll be switching this e2e test run to a different system now that won't block agents. Let's axe this for now.
To help with debugging RUN-2934
For #RUN-2991 (https://linear.app/replay/issue/RUN-2991) Add Profile pointer to RecordReplayService. Forward main implementation and API to RecordReplayService. Register record_replay dictionary in prefs.
kannanvijayan
force-pushed
the
kannan/persist-auth-and-refresh-tokens
branch
from
0057127
to
366623e
Compare
UI code needs access to the user token to pass it down to recorded render processes to get them to stream the recording. This exposes it and seems to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed up everything. The main C++ logic got moved over to
RecordReplayService, the auth flow can be triggered from withinRecordReplayManager, and open an external browser usingRecordReplayService, and the auth.ts code in the web container gets the right tokens and also correctly persists them to prefs.