feat(manager/ocb): implement providers support #31754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
can anyone help me , i cant figure out where i am failing |
|
You need have PR title which follows conventional commit conventions Also I see no documentation changes or unit tests as your choices in the form PR template forms suggest. |
secustor
changed the title
secustor
requested changes
Oct 2, 2024
There was a problem hiding this comment.
Revert all these changes.
Only changes in lib/modules/manager/ocb are necessary
There was a problem hiding this comment.
i just made the changes in , extract.ts and schema.ts , but how come these many changes have been made
There was a problem hiding this comment.
you probably worked on wrong base branch.
There was a problem hiding this comment.
Add tests to cover the providers too.
| @@ -52,7 +52,7 @@ export function extractPackageFile( | |||
| deps.push(...processModule(definition.extensions, 'extensions')); | |||
| deps.push(...processModule(definition.processors, 'processors')); | |||
| deps.push(...processModule(definition.receivers, 'receivers')); | |||
|
|
|||
| deps.push(...processModule(definition.providers,'providers')); | |||
There was a problem hiding this comment.
Suggested change
| deps.push(...processModule(definition.providers,'providers')); | |
| deps.push(...processModule(definition.providers,'providers')); | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context
closes #31747
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: