Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the reporting on Industry FE price scaling during calibration #950

Conversation

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

Lots of very small scaling differences caused hard-to-understand output.
Sample of new output:

pm_cesdata('2015','EUR','fehe_otherInd','price')            5.851E+00 x (1 +  2.220E-16) =  5.851E+00
pm_cesdata('2015','EUR','feelhth_otherInd','price')         3.263E+01 x (1 +  2.220E-16) =  3.263E+01
pm_cesdata('2015','EUR','feelwlth_otherInd','price')        1.233E+01 x (1 +  2.220E-16) =  1.233E+01
pm_cesdata('2020','EUR','feso_cement','price')              3.629E+00 x       9.875E-01  =  3.584E+00
pm_cesdata('2020','EUR','feli_cement','price')              1.364E+01 x       9.875E-01  =  1.347E+01
pm_cesdata('2020','EUR','fega_cement','price')              5.760E+00 x       9.875E-01  =  5.688E+00
pm_cesdata('2020','EUR','feh2_cement','price')              2.116E+01 x       9.875E-01  =  2.090E+01
pm_cesdata('2020','EUR','feel_cement','price')              8.253E+00 x       9.875E-01  =  8.150E+00
pm_cesdata('2020','EUR','feso_chemicals','price')           4.626E-01 x (1 -  1.237E-03) =  4.620E-01
pm_cesdata('2020','EUR','feli_chemicals','price')           1.738E+00 x (1 -  1.237E-03) =  1.736E+00
  • New feature

Checklist:

  • My code follows the coding etiquette
  • I have performed a self-review of my own code
  • Changes are commented, particularly in hard-to-understand areas
  • I have updated the in-code documentation
  • I have adjusted reporting where it was needed
  • The model compiles and runs successfully (Rscript start.R -q)

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q changed the title improve the reposting on Industry FE price scaling during calibration improve the reporting on Industry FE price scaling during calibration Aug 24, 2022
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member Author

@LaviniaBaumstark *bump*

Copy link
Member

@LaviniaBaumstark LaviniaBaumstark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better to read!

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q merged commit af701bd into remindmodel:develop Jun 29, 2023
1 check passed
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q deleted the dev/improve_Ind_FE_p_scaling_reporting branch June 29, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants