Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check configs for undefined scenarios #1818

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Sep 10, 2024

Purpose of this PR

  • avoid problems such as bugfix scenario naming in path_gdx column of EL2p0 project config #1817
  • check whether all path_gdx* columns are actually defined as a scenario in that file
  • do this check only when running make test, because in normal operation mode you might have specified a path to some old run etc. But that should rather not find its way into the repository

Type of change

  • New feature

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Copy link
Contributor

@gabriel-abrahao gabriel-abrahao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks Oli!

@orichters orichters merged commit f2a7143 into remindmodel:develop Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants