Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted project-configs to new magpie config structure #1800

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

FelicitasBeier
Copy link
Contributor

Purpose of this PR

MAgPIE has adjusted its scenario_config structure. Project-specific config files have been separated from the main scenario_config.csv (see magpiemodel/magpie#700).
This required an update of the config_coupled project scripts.

Furthermore, two project-specific config file (scenario_config_EL2p0DeepDive.csv and scenario_config_EL2p0DeepDive_coupled.csv) for the EAT2p0 project have been added.

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Further information (optional):

  • Test runs are here: /p/projects/magpie/users/beier/Test_Coupling/remind
  • Comparison of results (what changes by this PR?):

Copy link
Contributor

@dklein-pik dklein-pik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dklein-pik dklein-pik merged commit 3c29720 into remindmodel:develop Sep 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants