Make windoff independent from windon

[lecfab]

Purpose of this PR

So far, the development of wind offshore is tied to that of wind onshore. But offshore has specific requirements, as seen in the issue https://github.com/remindmodel/development_issues/issues/272.

• renames wind to windon
• removes the switch cm_wind_offshore that made windoff optional (but activated by default for years)
• changes the prn input data, while keeping the two options wind/windon for input data coming from mrremind
• groups equations that concern all teVRE

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

• Bug fix
• Refactoring
• New feature
• Minor change (default scenarios show only small differences)
• Fundamental change
• This change requires a documentation update

Checklist:

• My code follows the coding etiquette
• I performed a self-review of my own code
• I explained my changes within the PR, particularly in hard-to-understand areas
• I checked that the in-code documentation is up-to-date
• I adjusted the reporting in remind2 where it was needed windon replaces wind in reporting (still compatible with wind) pik-piam/remind2#634
• I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
• All automated model tests pass (FAIL 0 in the output of make test)
• The changelog CHANGELOG.md has been updated correctly

Further information (optional):

• Test runs are here: /p/tmp/fabricel/offshoreRemind09
• Comparison of results (what changes by this PR?): compScen-offshoreCascadeEU21-2024-09-20_11.32.20-H12.pdf

[robertpietzcker]

Actually, I find it potentially confusing if you read in a "all-wind target" as "windon" and then apply it to all wind.

so if you keep "wind" as an empty technology, this makes it very easy for you - just read in the all-wind target for the technology "wind", and then apply it to the sum of both.

so

sum(teWind(te)$(sameas(te,"windon") OR sameas(te,"windoff")), vm_cap(t,regi,te,"1"))
=g= p40_TechBound(t,regi,"wind") * 0.001

[lecfab]

Confirmed that bounds are for the sum of windOn and windOff:

mrremind/R/convertREN21.R
x_tmp[, , "Wind"] <- x_tmp[, , "Wind_ON"] + x_tmp[, , "Wind_OFF"]

Let's use pewin for such bounds, which then offers a choice: either we update mrremind to also output pewin bounds, or we re-separate the windon and windoff bounds (hopefully without to much trouble).

[robertpietzcker]

Great work, Fabrice!

I added many small comments, but there is one thing that I expect to potentially change results in an unwanted way - the removal of the rescaling of outputs from net to gross production in 04_PE_FE.
maybe I overlooked something, but currently it seems like you removed that, and I don't understand why.

[lecfab]

Hey, thanks a lot for your fast and thorough reviews.
I commented on most remarks above, but I'm not sure how to deal with the one about wind bounds @robertpietzcker.
I still need to understand from mrremind whether current bounds and targets are for all wind or only onshore. In the future, we will also need targets for offshore only. As "wind" is supposed to disappear from all_enty, maybe it would be clearer to have bounds mentioning explicitly windon or windoff, and possibly pewin when it's really a bound for the sum.
Any thoughts? If you are positive that bounds are all for the windon+windoff, then I'll implement that and ensure that mrremind changes wind to pewin asap.

[robertpietzcker]

no, I don't know if the bounds are for wind onshore or wind offshore.
I only assumed that you had found out they were for both, because the equation was adjusted such that it applies to the sum of both :-)

maybe using pewin for the read-in of "all wind" targets is a good approach.