fixes and improvements in inequality and damage modules #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onvergence criterium to nash convergence
orichters
approved these changes
Sep 20, 2023
core/sets.gms
Outdated
| @@ -754,123 +754,131 @@ sets | |||
| ext_regi "extended regions list (includes subsets of H12 regions)" | |||
| / | |||
There was a problem hiding this comment.
I don't understand these changes to core/sets.gms. Do they come from using REMIND-EU? I think they should not be pushed to the repository.
There was a problem hiding this comment.
Keine Ahnung, woher das kam. ich habe das rausgenommen.
| @@ -44,6 +44,7 @@ if ((cm_emiscen ne 1), | |||
| Execute_Loadpoint 'input_bau' p02_taxrev_redistr0_ref=v02_taxrev_Add.l; | |||
| Execute_Loadpoint 'input_bau' p02_cons_ref=vm_cons.l; | |||
| Execute_Loadpoint 'input_bau' p02_energyExp_ref=v02_energyExp.l; | |||
| Execute_Loadpoint 'input_bau' p02_damageFactor_ref=vm_damageFactor.l; | |||
There was a problem hiding this comment.
are you sure this is correct with input_bau here? Because if that is correct, I'm not sure whether this code is correct, that may potentially remove the path_gdx_bau as not needed if the 45 / 46 realizations don't need it.
There was a problem hiding this comment.
I changed it to input_ref. Didn't know about this code.
| @@ -8,7 +8,7 @@ | |||
| *** Load CES parameters based on current model configuration | |||
| *** ATTENTION the file name is replaced by the function start_run() | |||
| *##################### R SECTION START (CES INPUT) ########################## | |||
| $include "./modules/29_CES_parameters/load/input/indu_subsectors-buil_simple-tran_edge_esm-POP_pop_SSP2EU-GDP_gdp_SSP2EU-En_gdp_SSP2EU-Kap_debt_limit-Reg_62eff8f7.inc" | |||
There was a problem hiding this comment.
I think also this should not be pushed to the repo
| if(sameas(convMessage80,"damage"), | ||
| display "#### 11) The damage iteration did not converge."; | ||
| display "#### Check out below the values for pm_gmt_conv and pm_sccConvergenceMaxDeviation." | ||
| display "#### The should be below 0.05." |
bs538
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Type of change
(Make sure to delete from the Type-of-change list the items not relevant to your PR)
Checklist:
FAIL 0in the output ofmake test)