Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set pm_macSwitch(emiMacMagpie) = 0 also for 45/NPi #1401

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Sep 11, 2023

Purpose of this PR

  • when running REMIND standalone with the MAgPIE emulator, Emi|GHG|Agriculture grows if I switch on NDC carbon pricing
    image
  • reason: While adding 45/NPi realization, we forgot to switch off that emissions are being abated for emiMacMagpie. But in NDC, there was abatement switched off, so emissions in NDC were higher

Type of change

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • gamscompile works and I'm certain all automated model tests would pass (FAIL 0 in the output of make test) if renv wasn't corrupted given the very minor code changes
  • The changelog CHANGELOG.md has been updated correctly

Copy link
Contributor

@merfort merfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! Looks good.

@merfort merfort self-requested a review September 11, 2023 09:01
Copy link
Contributor

@dklein-pik dklein-pik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing this!

@orichters orichters merged commit 99861eb into remindmodel:develop Sep 11, 2023
2 checks passed
@orichters orichters deleted the pm_macSwitch branch January 31, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants