Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up test structure for data validation #1362

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

fbenke-pik
Copy link
Contributor

@fbenke-pik fbenke-pik commented Jul 17, 2023

Purpose of this PR

This PR sets up a test structure for data validation as part of creating a new release and provides sample tests derived from previous data issues.

Type of change

  • New feature

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas

@fbenke-pik
Copy link
Contributor Author

Lavinia, let's discuss the initial tests and decide next steps.

@fbenke-pik fbenke-pik marked this pull request as ready for review August 7, 2023 09:11
@fbenke-pik
Copy link
Contributor Author

@LaviniaBaumstark Let's merge these tests (they won't break anything) and then start working with the first set of tests as part of the next release cycle.

Copy link
Member

@LaviniaBaumstark LaviniaBaumstark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, let's merge it and test it in the next validation round

@fbenke-pik fbenke-pik merged commit ff3b804 into remindmodel:develop Aug 7, 2023
1 check passed
@fbenke-pik fbenke-pik deleted the modeltest branch August 7, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants