Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update income brackets for carbon price differentiation #1344

Closed
wants to merge 3 commits into from

Conversation

nicobauer
Copy link
Contributor

Purpose of this PR

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

  • Bug fix
  • Refactoring
  • New feature
  • [x ] Minor change (default scenarios show only small differences)
  • Fundamental change
  • This change requires a documentation update

Checklist:

  • [x ] My code follows the coding etiquette
  • [x ] I performed a self-review of my own code
  • [x ] I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • [x ] All automated model tests pass (FAIL 0 in the output of make test)

Further information (optional):

  • Test runs are here:
  • Comparison of results (what changes by this PR?):

@nicobauer nicobauer requested a review from strefler June 28, 2023 15:12
@nicobauer
Copy link
Contributor Author

Once more!

@LaviniaBaumstark
Copy link
Member

what is the status of this PR? can it be merged?

@nicobauer
Copy link
Contributor Author

Lavinia, I thought that already happened. Thus, Yes can be merged.

@LaviniaBaumstark
Copy link
Member

you now first need to solve the problems of codeCheck. Usually the person generating the PR also merges after all checks have passed and you have at least one approval.

@LaviniaBaumstark
Copy link
Member

do you plan to solve the conflicts and merge thsi PR?

@nicobauer
Copy link
Contributor Author

This issue has been solved in a different pull-request by Laurin. You can close it and abandon it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants