Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error should not be thrown on HTTP error when noThrow is set. #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dirklectisch
Copy link

I noticed that the noThrow flag only disable throwing for GraphQL errors in the response. For HTTP errors codes coming back from the server an error will be thrown currently even though you set the flag.

In my opinion it makes sense to do the same for HTTP errors in the response. You either handle all the errors yourself or you let the middleware stack throw errors.

@tslater
Copy link

tslater commented Dec 3, 2021

I seem to be not having any luck with noThrow, is this still a thing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants