Allow shared service drop-in directory #681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Systemd reads all conf files from a service drop-in directory and merges
them.
This change enables the following use case:
Tuning unrelated but local changes can be put into - say:
/etc/systemd/system/sfptpd.service.d/local.conf
while a simple tuning such as the process affinity mask is rolled out
via a tuned profile, like this:
`tuned.conf` snippet:
```
[service]
service.sfptpd=,file:${i:PROFILE_DIR}/tuned-sfptpd.conf
```
`tuned-sfptpd.conf`:
```
[Service]
CPUAffinity=32
```
---
Arguably, this is a natural change, i.e. it establishes symmetry in
`cfg_install()` to `cfg_uninstall()`, because `cfg_uninstall()` already
allows for the service drop-in directory not being empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Systemd reads all conf files from a service drop-in directory and merges them.
This change enables the following use case:
Tuning unrelated but local changes can be put into - say:
while a simple tuning such as the process affinity mask is rolled out via a tuned profile, like this:
tuned.confsnippet:tuned-sfptpd.conf:Arguably, this is a natural change, i.e. it establishes symmetry in
cfg_install()tocfg_uninstall(), becausecfg_uninstall()already allows for the service drop-in directory not being empty.