Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding a flag for csv timeout for check operator cmd #1198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adding a flag for csv timeout for check operator cmd #1198

wants to merge 1 commit into from
+69 −9

Conversation

acornett21
Copy link
Contributor

@acornett21 acornett21 commented Sep 16, 2024 •
edited
Loading

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@coveralls
Copy link

coveralls commented Sep 16, 2024 •
edited
Loading

Coverage Status

coverage: 84.472% (+0.009%) from 84.463%
when pulling 89aa5a8 on acornett21:add_csv_timeout_flag
into 755831a on redhat-openshift-ecosystem:main.

@dcibot
Copy link

dcibot commented Sep 16, 2024

from change #1198:

bcrochet
bcrochet reviewed Sep 16, 2024
View reviewed changes
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to ignore, but you added a functional option in one place, and pass it bare in another. I'd keep it a functional option everywhere.

internal/engine/engine.go Outdated Show resolved Hide resolved
komish
komish requested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two changes we might be able to make to protect users from setting their timeout to 0 seconds.

bcrochet
bcrochet reviewed Sep 25, 2024
View reviewed changes
cmd/preflight/cmd/check_operator.go Outdated Show resolved Hide resolved
internal/runtime/config_test.go Outdated Show resolved Hide resolved
@acornett21 acornett21 force-pushed the add_csv_timeout_flag branch 2 times, most recently from 372c36a to c641cbf Compare September 30, 2024 17:37
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, skattoju

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,skattoju]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dcibot
Copy link

dcibot commented Sep 30, 2024

from change #1198:

@acornett21
Copy link
Contributor Author

/test 4.17-e2e

3 similar comments
@acornett21
Copy link
Contributor Author

/test 4.17-e2e

@acornett21
Copy link
Contributor Author

/test 4.17-e2e

@acornett21
Copy link
Contributor Author

/test 4.17-e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcrochet bcrochet bcrochet left review comments

@skattoju skattoju skattoju approved these changes

@komish komish komish requested changes

@tonytcampbell tonytcampbell Awaiting requested review from tonytcampbell

Assignees

@komish komish

@skattoju skattoju

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose csvTimeout and possibly subscriptionTimeout as Configurable ENV's
6 participants
@acornett21 @coveralls @dcibot @bcrochet @komish @skattoju