Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

item-12-147 #392

Merged
merged 1 commit into from
Sep 27, 2023
Merged

item-12-147 #392

merged 1 commit into from
Sep 27, 2023

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Sep 7, 2023

Description

Screenshot from 2023-09-07 11-24-44

Considerations

Recent IBM Cloud updates were made to the guide: #359 . The request for a usable IBM eServer System i term is no longer valid.

Issue

Closes number 12 in #147

Preview link

See ibm-eserver-system-i and iSeries

@dfitzmau dfitzmau added Glossary entry Topics that add or modify glossary entries On hold Topics that are temporarily on hold labels Sep 7, 2023
@dfitzmau dfitzmau force-pushed the item-12-147 branch 2 times, most recently from 69e41a3 to a858783 Compare September 7, 2023 11:35
@dfitzmau dfitzmau removed the On hold Topics that are temporarily on hold label Sep 7, 2023
Copy link
Collaborator

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One item about the "no" designation, but I'd also like @SNiemann15 to review this before we move forward with it, since she's the expert on these product names.

@SNiemann15 can you PTAL?

@@ -18,6 +18,16 @@

*See also*:

[[ibm-eserver-system-i]]
==== image:images/yes.png[no] IBM eServer System i (noun)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want this to be a use it: no, then it has to be "no.png" here and the "use it" field has to be set to "no".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, and thanks for reviewing. Updated.

@SNiemann15
Copy link
Contributor

One item about the "no" designation, but I'd also like @SNiemann15 to review this before we move forward with it, since she's the expert on these product names.

@SNiemann15 can you PTAL?

Correct IBM eserver system i is also one of the previous names and shouldn't be used. Wikipedia gives a good overview of all the names (they are just missing the latest change to IBM Power)

@SNiemann15
Copy link
Contributor

/lgtm

@dfitzmau
Copy link
Contributor Author

Reference i

Thanks for checking, @SNiemann15 . Would you be OK to add an approval tick to this PR; that is Files changed > Review changes > Approve.

Copy link
Collaborator

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@mportman12 mportman12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mportman12 mportman12 merged commit f64e004 into redhat-documentation:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Glossary entry Topics that add or modify glossary entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants