Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding helper-operator, helper-status-checker and update-clusterversi… #535

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

tjungbauer
Copy link
Contributor

adding helper-operator, helper-status-checker and update-clusterversion as a first test

What is this PR About?

Added some charts to see how well it is going (Merging charts.stderr.at to redhat-cop)

cc: @redhat-cop/day-in-the-life

@ckavili
Copy link
Contributor

ckavili commented Jun 24, 2024

hey @tjungbauer, many thanks for the PR! 🚀 I especially love the detailed documentation 🙌 I see that helper-operator and helper-status-checker have similar capabilities with the existing operators-installer chart here. Do you think we can merge these somehow? like bringing enabling console link bits into the existing chart for example 🤔

@tjungbauer
Copy link
Contributor Author

Hi @ckavili I personally would keep it separated, since they have two different purposes and are also the base for the operators I am trying to PR :)

@ckavili ckavili requested a review from eformat June 26, 2024 09:55
@ckavili
Copy link
Contributor

ckavili commented Jun 26, 2024

I wouldn't mind, to be honest..I'm more on the side of maintaining only one chart to deploy operators..but also I just realized we still have this operatorhub chart hanging out 😅 so we can have your helper-operator chart instead..but first, I'd like to ask for a second opinion @eformat 🙈

@tjungbauer
Copy link
Contributor Author

sure, just keep in mind that any operator here (https://charts.stderr.at/) is using the helper-operator and helper-status-checker.
I did not put everything into the PR ... I started small :)

@ckavili
Copy link
Contributor

ckavili commented Jul 4, 2024

hey @tjungbauer , linter is complaining about either too many empty blank lines ( Error: 13:1 [empty-lines] too many blank lines (1 > 0)) or no empty lines. Would you mind to check those? then I'll smash the PR in 🚀 thanks a lot!

@ckavili ckavili merged commit 9b524b6 into redhat-cop:main Jul 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants