Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dotnet image to the CI pipeline #29

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

rafaeltuelho
Copy link
Contributor

This PR adds the dotnet image to the CI pipeline.

@etsauer
Copy link
Contributor

etsauer commented Sep 20, 2024

hey @rafaeltuelho thanks for this! Before we can merge this, we need to get a new image repo created in quay.io. The redhat-cop org has some ansible automation that manages the quay.io/redhat-cop org. In order to get the image repo created, could you open a PR against https://github.com/redhat-cop/org, specifically adding an entry for devspaces-dotnet-8 to the ansible inventory like so: https://github.com/redhat-cop/org/blob/main/ansible/inventory/group_vars/all.yml#L287-L298

@rafaeltuelho
Copy link
Contributor Author

@etsauer, PR created there redhat-cop/org#910

Copy link
Contributor

@etsauer etsauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@etsauer etsauer merged commit 661a1fc into redhat-cop:main Sep 20, 2024
10 checks passed
@rafaeltuelho rafaeltuelho deleted the add-dotnet8 branch September 23, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants