Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for workspace.rc to set custom env #26

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

cgruver
Copy link
Contributor

@cgruver cgruver commented Aug 22, 2024

No description provided.

@cgruver cgruver requested a review from etsauer August 22, 2024 16:38
@etsauer
Copy link
Contributor

etsauer commented Aug 22, 2024

so @cgruver you want this setup to be supported in both the developer-base module AND the custom-tooling module?

@cgruver
Copy link
Contributor Author

cgruver commented Aug 22, 2024

so @cgruver you want this setup to be supported in both the developer-base module AND the custom-tooling module?

@etsauer Two different use cases.

  1. Developer Base - creates .zshrc and .bashrc in $HOME, if they don't already exist. for example, if the user creates their own persistent $HOME instead of using the container default.
  2. Custom Tooling is embedding a default $HOME with .zshrc and .bashrc already created.

Copy link
Contributor

@etsauer etsauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@etsauer etsauer merged commit d6433bb into redhat-cop:main Aug 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants