Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed to placement #76

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

avd-sagare
Copy link

No description provided.

Signed-off-by: Avdhoot <[email protected]>
@avd-sagare avd-sagare force-pushed the new_sub branch 3 times, most recently from a413567 to a723e39 Compare May 11, 2024 12:18
Copy link
Contributor

@parikshithb parikshithb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, better run mdr basic ci test once to validate these changes before merging.

Copy link
Contributor

@Akarsha-rai Akarsha-rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to change in all workload path

    {name: "busybox-1", workload_dir: "mdr/subscriptions/busybox-app-1", pod_count: 2, pvc_count: 2},
    {name: "busybox-2", workload_dir: "mdr/subscriptions/busybox-app-2", pod_count: 2, pvc_count: 2},
    {name: "busybox-3", workload_dir: "mdr/subscriptions/busybox-app-3", pod_count: 2, pvc_count: 2},
    {name: "busybox-4", workload_dir: "mdr/subscriptions/busybox-app-4", pod_count: 2, pvc_count: 2},
    {name: "busybox-5", workload_dir: "mdr/subscriptions/busybox-app-5", pod_count: 2, pvc_count: 2},

@avd-sagare
Copy link
Author

looks good, better run mdr basic ci test once to validate these changes before merging.

Sure. I have tests this while testing replace cluster PR. Also will run basic CI tests

@avd-sagare
Copy link
Author

It would be good to change in all workload path

    {name: "busybox-1", workload_dir: "mdr/subscriptions/busybox-app-1", pod_count: 2, pvc_count: 2},
    {name: "busybox-2", workload_dir: "mdr/subscriptions/busybox-app-2", pod_count: 2, pvc_count: 2},
    {name: "busybox-3", workload_dir: "mdr/subscriptions/busybox-app-3", pod_count: 2, pvc_count: 2},
    {name: "busybox-4", workload_dir: "mdr/subscriptions/busybox-app-4", pod_count: 2, pvc_count: 2},
    {name: "busybox-5", workload_dir: "mdr/subscriptions/busybox-app-5", pod_count: 2, pvc_count: 2},

Can I do in next PR?

@avd-sagare
Copy link
Author

PR validation is passed with app deployment, failover and relocate.

@avd-sagare
Copy link
Author

logs_76.txt

@avd-sagare avd-sagare requested a review from a team August 14, 2024 12:04
Copy link
Contributor

openshift-ci bot commented Aug 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Akarsha-rai, avd-sagare, parikshithb, prsurve

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6915c6a into red-hat-storage:master Aug 19, 2024
2 checks passed
@prsurve
Copy link
Contributor

prsurve commented Aug 19, 2024

/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants