-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed to placement #76
Changed to placement #76
Conversation
Signed-off-by: Avdhoot <[email protected]>
a413567
to
a723e39
Compare
Signed-off-by: [email protected] Signed-off-by: [email protected] <[email protected]> Signed-off-by: [email protected] <[email protected]> Signed-off-by: [email protected] <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, better run mdr basic ci test once to validate these changes before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to change in all workload path
{name: "busybox-1", workload_dir: "mdr/subscriptions/busybox-app-1", pod_count: 2, pvc_count: 2},
{name: "busybox-2", workload_dir: "mdr/subscriptions/busybox-app-2", pod_count: 2, pvc_count: 2},
{name: "busybox-3", workload_dir: "mdr/subscriptions/busybox-app-3", pod_count: 2, pvc_count: 2},
{name: "busybox-4", workload_dir: "mdr/subscriptions/busybox-app-4", pod_count: 2, pvc_count: 2},
{name: "busybox-5", workload_dir: "mdr/subscriptions/busybox-app-5", pod_count: 2, pvc_count: 2},
Sure. I have tests this while testing replace cluster PR. Also will run basic CI tests |
Can I do in next PR? |
PR validation is passed with app deployment, failover and relocate. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Akarsha-rai, avd-sagare, parikshithb, prsurve The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6915c6a
into
red-hat-storage:master
/approve |
No description provided.