-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom taints and toleration node operation #9920
base: master
Are you sure you want to change the base?
Custom taints and toleration node operation #9920
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vkathole The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tests/functional/z_cluster/nodes/test_non_ocs_taint_and_toleration.py
Outdated
Show resolved
Hide resolved
tests/functional/z_cluster/nodes/test_non_ocs_taint_and_toleration.py
Outdated
Show resolved
Hide resolved
tests/functional/z_cluster/nodes/test_non_ocs_taint_and_toleration.py
Outdated
Show resolved
Hide resolved
tests/functional/z_cluster/nodes/test_non_ocs_taint_and_toleration.py
Outdated
Show resolved
Hide resolved
ocs_ci/ocs/resources/pod.py
Outdated
toleration_key (str): The toleration key to check | ||
""" | ||
|
||
sub_list = ocp.get_all_resource_names_of_a_kind(kind=constants.SUBSCRIPTION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are getting all the resource names of a particular kind and getting its obj instantiating ocp class. Instead, you can directly get all the subscription obj list as below ,
sub_obj_list = ocp.OCP(namespace=config.ENV_DATA["cluster_namespace"], kind=constants.SUBSCRIPTION).get()
tests/functional/z_cluster/nodes/test_non_ocs_taint_and_toleration.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Vishakha Kathole <[email protected]>
273c9cf
to
ee87c8d
Compare
Signed-off-by: vkathole <[email protected]>
Signed-off-by: vkathole <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: tier4b
PR Test Path: tests/functional/z_cluster/nodes/test_non_ocs_taint_and_toleration.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
Job UNSTABLE (some or all tests failed).
Signed-off-by: vkathole <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: vkathole-t26
Cluster Configuration:
PR Test Suite: tier4b
PR Test Path: tests/functional/z_cluster/nodes/test_non_ocs_taint_and_toleration.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
Job UNSTABLE (some or all tests failed).
Signed-off-by: vkathole <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: tier4b
PR Test Path: tests/functional/z_cluster/nodes/test_non_ocs_taint_and_toleration.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
Job UNSTABLE (some or all tests failed).
No description provided.