Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom taints and toleration node operation #9920

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

vkathole
Copy link
Contributor

@vkathole vkathole commented Jun 7, 2024

No description provided.

@vkathole vkathole requested review from a team as code owners June 7, 2024 10:27
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Jun 7, 2024
@vkathole vkathole added team/e2e E2E team related issues/PRs and removed size/L PR that changes 100-499 lines labels Jun 7, 2024
Copy link

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vkathole

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

toleration_key (str): The toleration key to check
"""

sub_list = ocp.get_all_resource_names_of_a_kind(kind=constants.SUBSCRIPTION)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are getting all the resource names of a particular kind and getting its obj instantiating ocp class. Instead, you can directly get all the subscription obj list as below ,
sub_obj_list = ocp.OCP(namespace=config.ENV_DATA["cluster_namespace"], kind=constants.SUBSCRIPTION).get()

ocs_ci/ocs/resources/pod.py Outdated Show resolved Hide resolved
ocs_ci/ocs/resources/pod.py Outdated Show resolved Hide resolved
ocs_ci/ocs/resources/pod.py Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Sep 19, 2024
Signed-off-by: vkathole <[email protected]>
Signed-off-by: vkathole <[email protected]>
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier4b
PR Test Path: tests/functional/z_cluster/nodes/test_non_ocs_taint_and_toleration.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job UNSTABLE (some or all tests failed).

Signed-off-by: vkathole <[email protected]>
@pull-request-size pull-request-size bot added size/L PR that changes 100-499 lines and removed size/M PR that changes 30-99 lines labels Sep 26, 2024
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: vkathole-t26
Cluster Configuration:
PR Test Suite: tier4b
PR Test Path: tests/functional/z_cluster/nodes/test_non_ocs_taint_and_toleration.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job UNSTABLE (some or all tests failed).

Signed-off-by: vkathole <[email protected]>
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier4b
PR Test Path: tests/functional/z_cluster/nodes/test_non_ocs_taint_and_toleration.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job UNSTABLE (some or all tests failed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L PR that changes 100-499 lines team/e2e E2E team related issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants