Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bucket policy test cases for for NotPrincipal, NotAction and NotResource. #9688

Merged
merged 9 commits into from
May 22, 2024
Merged

Bucket policy test cases for for NotPrincipal, NotAction and NotResource. #9688

merged 9 commits into from
May 22, 2024

Conversation

tiffanyn108
Copy link
Contributor

Test bucket policy for for NotPrincipal, NotAction and NotResource.

@tiffanyn108 tiffanyn108 added Needs Testing Run tests and provide logs link MCG Multi Cloud Gateway / NooBaa related issues Squad/Red labels Apr 16, 2024
@tiffanyn108 tiffanyn108 requested review from a team as code owners April 16, 2024 19:27
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Apr 16, 2024
ocs-ci
ocs-ci reviewed Apr 16, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: tunguyen-416
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/object/mcg/test_bucket_policy.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci
ocs-ci reviewed Apr 17, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/object/mcg/test_bucket_policy.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

@tiffanyn108
Copy link
Contributor Author

PR validation

Cluster Name: Cluster Configuration: PR Test Suite: tier1 PR Test Path: tests/functional/object/mcg/test_bucket_policy.py Additional Test Params: OCP VERSION: 4.16 OCS VERSION: 4.16 tested against branch: master

Job UNSTABLE (some or all tests failed).

tests.functional.object.mcg.test_bucket_policy.TestS3BucketPolicy.test_bucket_policy_elements_NotAction[Allow] Failed due to product issue: https://bugzilla.redhat.com/show_bug.cgi?id=2275040

@tiffanyn108 tiffanyn108 added Verified Mark when PR was verified and log provided and removed Needs Testing Run tests and provide logs link labels Apr 17, 2024
@mashetty330 mashetty330 mentioned this pull request Apr 17, 2024
Closed
udaysk23
udaysk23 requested changes May 3, 2024
View reviewed changes
ocs_ci/ocs/resources/bucket_policy.py Outdated Show resolved Hide resolved
ocs_ci/ocs/resources/bucket_policy.py Outdated Show resolved Hide resolved
@tiffanyn108
Add bucket policy test cases.
b22b484 
Signed-off-by: tiffanyn108 <[email protected]>
@tiffanyn108
.
34df00c 
Signed-off-by: tiffanyn108 <[email protected]>
@tiffanyn108
Add bucket policy test cases for NotPrincipal, NotAction and NotResou…
329ae95 
…rce.

Signed-off-by: tiffanyn108 <[email protected]>
@tiffanyn108
.
aa93905 
Signed-off-by: tiffanyn108 <[email protected]>
@tiffanyn108
.
956395d 
Signed-off-by: tiffanyn108 <[email protected]>
@tiffanyn108
.
b9f3def 
Signed-off-by: tiffanyn108 <[email protected]>
@tiffanyn108
.
b3e2f52 
Signed-off-by: tiffanyn108 <[email protected]>
@tiffanyn108
Fixed code with reviewer comments.
2d015ee 
Signed-off-by: tiffanyn108 <[email protected]>
@tiffanyn108
Updated the login.info for gen_bucket_policy()
fc73df7 
Signed-off-by: tiffanyn108 <[email protected]>
@openshift-ci openshift-ci bot added the lgtm label May 14, 2024
sagihirshfeld
sagihirshfeld approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@sagihirshfeld sagihirshfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: keesturam, sagihirshfeld, tiffanyn108, udaysk23

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@keesturam keesturam merged commit 59f705b into red-hat-storage:master May 22, 2024
5 of 6 checks passed
amr1ta pushed a commit to amr1ta/ocs-ci that referenced this pull request May 28, 2024
@tiffanyn108 @amr1ta
Bucket policy test cases for for NotPrincipal, NotAction and NotResou…
c7c7a2d 
…rce. (red-hat-storage#9688)

Signed-off-by: tiffanyn108 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@keesturam keesturam keesturam approved these changes

@sagihirshfeld sagihirshfeld sagihirshfeld approved these changes

@udaysk23 udaysk23 udaysk23 approved these changes

Assignees

@keesturam keesturam

@sagihirshfeld sagihirshfeld

@udaysk23 udaysk23

Labels
lgtm MCG Multi Cloud Gateway / NooBaa related issues size/L PR that changes 100-499 lines Squad/Red Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiffanyn108 @keesturam @sagihirshfeld @ocs-ci @udaysk23