Write file to rgw bucket from client #9680
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fbalak <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fbalak The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: fbalak <[email protected]>
Signed-off-by: fbalak <[email protected]>
Signed-off-by: fbalak <[email protected]>
Signed-off-by: fbalak <[email protected]>
Signed-off-by: fbalak <[email protected]>
fbalak
force-pushed
the
provider-client-rgw-write
branch
from
4d278c7
to
018487a
Compare
Signed-off-by: fbalak <[email protected]>
Signed-off-by: fbalak <[email protected]>
Signed-off-by: fbalak <[email protected]>
fbalak
requested review from
sagihirshfeld,
udaysk23,
DanielOsypenko,
jilju,
ebondare,
amr1ta,
suchita-g and
yitzhak12
ebondare
reviewed
May 29, 2024
|
|
||
| @pytest.fixture | ||
| def return_to_original_context(): | ||
| """ |
There was a problem hiding this comment.
This fixture looks useful and generic, are you sure you want to use it only for rgw tests?
udaysk23
reviewed
Aug 16, 2024
Comment on lines
+74
to
+76
| assert set(downloaded_files).issubset( | ||
| obj.key for obj in rgw_obj.s3_list_all_objects_in_bucket(bucketname) | ||
| ) |
There was a problem hiding this comment.
@fbalak We can use verify_s3_object_integrity method from bucket_utils.py file for object integrity.
Please refer below link:
ocs-ci/ocs_ci/ocs/bucket_utils.py
Line 137 in 9a688b5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.