Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ordering for test_failure_propagator #9652

Conversation

vavuthu
Copy link
Contributor

@vavuthu vavuthu commented Apr 8, 2024

After we moved to pytest-order from pytest-ordering, test_failure_propagator order is broken.

Signed-off-by: vavuthu [email protected]

@vavuthu vavuthu requested a review from a team as a code owner April 8, 2024 17:24
@vavuthu vavuthu added team/ecosystem Ecosystem team related issues/PRs Needs Testing Run tests and provide logs link labels Apr 8, 2024
Copy link

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ebenahar, petr-balogh, vavuthu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@petr-balogh
Copy link
Member

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link
Collaborator

@petr-balogh: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@petr-balogh petr-balogh merged commit 9de9336 into red-hat-storage:master Apr 8, 2024
5 of 7 checks passed
@openshift-cherrypick-robot
Copy link
Collaborator

@petr-balogh: new pull request created: #9654

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@petr-balogh
Copy link
Member

@vavuthu by mistake I merged without verification. Hope it will work fine :)

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: acceptance
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

@vavuthu
Copy link
Contributor Author

vavuthu commented Apr 9, 2024

@vavuthu by mistake I merged without verification. Hope it will work fine :)

I verified locally before raising PR. For safer side, triggered acceptance testing which is working ( order ) as expected. we are good here
logs:

2024-04-09 00:51:11  tests/cross_functional/system_test/multicluster/test_acceptance.py::TestAcceptance::test_acceptance 
2024-04-09 00:51:11  -------------------------------- live log setup --------------------------------
2024-04-09 00:51:11  19:21:11 - MainThread - ocs_ci.utility.utils - INFO  - testrun_name: OCS4-16-Downstream-OCP4-16-VSPHERE-UPI-1AZ-RHCOS-3M-3W-acceptance
.
.
.
2024-04-09 02:12:25  tests/test_failure_propagator.py::TestFailurePropagator::test_failure_propagator 
2024-04-09 02:12:25  -------------------------------- live log setup --------------------------------
2024-04-09 02:12:25  20:42:25 - MainThread - ocs_ci.utility.utils - INFO  - testrun_name: OCS4-16-Downstream-OCP4-16-VSPHERE-UPI-1AZ-RHCOS-3M-3W-acceptance

@vavuthu vavuthu added Verified Mark when PR was verified and log provided and removed Needs Testing Run tests and provide logs link labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/XS team/ecosystem Ecosystem team related issues/PRs Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants