Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replica1 tests #9501

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Replica1 tests #9501

merged 7 commits into from
Aug 22, 2024

Conversation

AviadP
Copy link
Contributor

@AviadP AviadP commented Mar 18, 2024

infra and test cases for replica-1 feature support

@AviadP AviadP requested a review from a team as a code owner March 18, 2024 07:39
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Mar 18, 2024
@pull-request-size pull-request-size bot added size/L PR that changes 100-499 lines and removed size/M PR that changes 30-99 lines labels Mar 18, 2024
@AviadP AviadP changed the title WIP - Replica1 tests Replica1 tests Apr 3, 2024
ocs_ci/ocs/replica_one.py Outdated Show resolved Hide resolved
@AviadP AviadP added the Test Case A test case PR label Apr 10, 2024
ocs_ci/ocs/replica_one.py Outdated Show resolved Hide resolved
ocs_ci/ocs/replica_one.py Outdated Show resolved Hide resolved
ocs_ci/ocs/replica_one.py Outdated Show resolved Hide resolved
ocs_ci/ocs/replica_one.py Outdated Show resolved Hide resolved
ocs_ci/ocs/replica_one.py Outdated Show resolved Hide resolved
ocs_ci/ocs/replica_one.py Outdated Show resolved Hide resolved
@AviadP AviadP changed the title Replica1 tests WIP-Replica1 tests Apr 16, 2024
@AviadP AviadP requested a review from a team as a code owner April 16, 2024 12:51
@pull-request-size pull-request-size bot added size/XL and removed size/L PR that changes 100-499 lines labels Jun 24, 2024
@AviadP AviadP changed the title WIP-Replica1 tests Replica1 tests Jun 24, 2024
@AviadP AviadP requested review from ebenahar and shyRozen June 27, 2024 08:32
cephblockpools_names = list()
prefix = DEFAULT_CEPHBLOCKPOOL
items = cbp_object.data.get("items", [])
for i in range(len(items)):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can little bit speedup the code by using list comprehensions to create cephblockpools_names and failure_domains

  cephblockpools_names = [
        item["metadata"]["name"]
        for item in cbp_object.data.get("items", [])
        if "name" in item["metadata"]
    ]
    log.info(f"Cephblockpool names: {cephblockpools_names}")

    failure_domains = [
        name[len(prefix):].lstrip("-")
        for name in cephblockpools_names
        if name.startswith(prefix)
    ]

    log.info(f"Failure domains: {failure_domains}")
    ```

ocs_ci/ocs/replica_one.py Show resolved Hide resolved
Copy link
Contributor

@ebenahar ebenahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work Aviad

ocs_ci/ocs/replica_one.py Outdated Show resolved Hide resolved
ocs_ci/ocs/replica_one.py Outdated Show resolved Hide resolved
ocs_ci/ocs/replica_one.py Outdated Show resolved Hide resolved
tests/functional/storageclass/test_replica1.py Outdated Show resolved Hide resolved
Removed some un used code, added missing docstrings

Signed-off-by: Aviadp <[email protected]>
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/storageclass/test_replica1.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job FAILED (installation failed, tests not executed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/storageclass/test_replica1.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job FAILED (installation failed, tests not executed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/storageclass/test_replica1.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job FAILED (installation failed, tests not executed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite: tier1
PR Test Path: tests/functional/storageclass/test_replica1.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job FAILED (installation failed, tests not executed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: apolak-aug13
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite: tier1
PR Test Path: tests/functional/storageclass/test_replica1.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: apolak-au19
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/storageclass/test_replica1.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job PASSED.

@AviadP AviadP added the Verified Mark when PR was verified and log provided label Aug 20, 2024
Signed-off-by: Aviadp <[email protected]>
Copy link

openshift-ci bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AviadP, ebenahar, paraggit

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ebenahar ebenahar merged commit 1287db5 into red-hat-storage:master Aug 22, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/XL Test Case A test case PR Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants