-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replica1 tests #9501
Replica1 tests #9501
Conversation
cephblockpools_names = list() | ||
prefix = DEFAULT_CEPHBLOCKPOOL | ||
items = cbp_object.data.get("items", []) | ||
for i in range(len(items)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can little bit speedup the code by using list comprehensions to create cephblockpools_names and failure_domains
cephblockpools_names = [
item["metadata"]["name"]
for item in cbp_object.data.get("items", [])
if "name" in item["metadata"]
]
log.info(f"Cephblockpool names: {cephblockpools_names}")
failure_domains = [
name[len(prefix):].lstrip("-")
for name in cephblockpools_names
if name.startswith(prefix)
]
log.info(f"Failure domains: {failure_domains}")
```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work Aviad
Signed-off-by: Aviadp <[email protected]>
Removed some un used code, added missing docstrings Signed-off-by: Aviadp <[email protected]>
Signed-off-by: Aviadp <[email protected]>
Signed-off-by: Aviadp <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/storageclass/test_replica1.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
Job FAILED (installation failed, tests not executed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/storageclass/test_replica1.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
Job FAILED (installation failed, tests not executed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/storageclass/test_replica1.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master
Job FAILED (installation failed, tests not executed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite: tier1
PR Test Path: tests/functional/storageclass/test_replica1.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master
Job FAILED (installation failed, tests not executed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: apolak-aug13
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite: tier1
PR Test Path: tests/functional/storageclass/test_replica1.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master
Job UNSTABLE (some or all tests failed).
Signed-off-by: Aviadp <[email protected]>
Signed-off-by: Aviadp <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: apolak-au19
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/storageclass/test_replica1.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
Signed-off-by: Aviadp <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AviadP, ebenahar, paraggit The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
infra and test cases for replica-1 feature support