Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect ceph data for External mode #10594

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Collect ceph data for External mode #10594

wants to merge 3 commits into from
+204 −0

Conversation

OdedViner
Copy link
Contributor

@OdedViner OdedViner requested a review from a team as a code owner September 28, 2024 20:35
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Sep 28, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: OdedViner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

petr-balogh
petr-balogh reviewed Sep 30, 2024
View reviewed changes
Docker_files/scripts/mg_external.sh Outdated
@@ -0,0 +1,151 @@
#!/usr/bin/env bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if Docker_files is right folder. I think we should move it or create other one as it's not related to any docker file or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petr-balogh petr-balogh petr-balogh left review comments

@sidhant-agrawal sidhant-agrawal Awaiting requested review from sidhant-agrawal

@nehaberry nehaberry Awaiting requested review from nehaberry

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
size/L PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OdedViner @petr-balogh