Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation of pod deletion #10582

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

keemano
Copy link
Contributor

@keemano keemano commented Sep 26, 2024

This PR addresses the issue 9560

In this test, reclaim space job was created immediately after the deletion of app pod, which caused the reclaim space job failure.
There was a miss to validate pod deletion prior to the creation of the reclaim space job. This PR adds the validation of pod deletion.

@keemano keemano requested a review from a team as a code owner September 26, 2024 08:37
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Sep 26, 2024
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unknown PR validation on existing cluster

Cluster Name: kmanohar-c113
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/functional/pv/space_reclaim/test_rbd_space_reclaim.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job state: ABORTED.

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: kmanohar-c113
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/functional/pv/space_reclaim/test_rbd_space_reclaim.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job PASSED.

@keemano keemano added the Verified Mark when PR was verified and log provided label Sep 26, 2024
@openshift-ci openshift-ci bot added the lgtm label Sep 26, 2024
@keemano keemano requested review from nehaberry and a team September 26, 2024 09:55
Copy link

openshift-ci bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jilju, keemano, sidhant-agrawal

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/S PR that changes 10-29 lines Squad/Green Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants