-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce deploy_hosted_clusters configuration parameter #10547
base: master
Are you sure you want to change the base?
introduce deploy_hosted_clusters configuration parameter #10547
Conversation
- introduce specific configuration parameter to enable deployment of hosted clusters: `DEPLOYMENT["deploy_hosted_clusters"]` Signed-off-by: Daniel Horak <[email protected]>
Signed-off-by: Daniel Horak <[email protected]>
and not config.ENV_DATA["skip_ocs_deployment"] | ||
if config.ENV_DATA.get("clusters", False) and ( | ||
not config.ENV_DATA["skip_ocs_deployment"] | ||
or config.DEPLOYMENT.get("deploy_hosted_clusters") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we document this value: deploy_hosted_clusters ?
In config/readme.md file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated 623231f
Signed-off-by: Daniel Horak <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dahorak, petr-balogh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
DEPLOYMENT["deploy_hosted_clusters"]