Syncing latest changes from master for noobaa-core

.clang-format

@@ -17,7 +17,7 @@ BinPackParameters: false
 FixNamespaceComments: true
 NamespaceIndentation: Inner
 PointerAlignment: Left
-# IndentPPDirectives: AfterHash
+IndentPPDirectives: BeforeHash
 
 AlignOperands: DontAlign
 AlignAfterOpenBracket: DontAlign

.dockerignore

@@ -1,15 +1,12 @@
 .git/
 node_modules/
-frontend/node_modules/
-frontend/dist/
 build/
 coverage/
 logs/
 *.log
-metadata_storage/
-noobaa_storage/
+storage/
 heapdump-*
 .vscode/
-*.STASH
+*.IGNORE
 .nyc_output/
 *Dockerfile

.editorconfig

@@ -0,0 +1,14 @@
+[*.js]
+charset = utf-8
+indent_style = space
+indent_size = 4
+end_of_line = lf
+trim_trailing_whitespace = true
+insert_final_newline = true
+
+[*.{cpp,cc,c,hpp,h,hh}]
+charset = utf-8
+indent_style = space
+indent_size = 4
+end_of_line = lf
+trim_trailing_whitespace = true

.eslintignore

@@ -1 +1 @@
-src/test/system_tests/s3-tests/**
+src/test/system_tests/ceph_s3_tests/s3-tests/**

.eslintrc.js

@@ -1,20 +1,29 @@
+/* Copyright (C) 2016 NooBaa */
+'use strict';
+
+const CURRENT_YEAR = new Date().getFullYear();
+
 module.exports = {
 
     // prevent from looking up other config files in containing folders
     root: true,
 
-    // our environment is node.js with it's es6 extensions
+    // Our environment is node.js
     env: {
         node: true,
-        es6: true,
+        es2022: true,
+        jest: true,
     },
 
+    // See https://eslint.org/docs/latest/user-guide/configuring/language-options#specifying-environments
     parserOptions: {
-        ecmaVersion: 11, // 2020
+        ecmaVersion: 13, // es2022
     },
 
 
     plugins: [
+        // stylistic validates style related rules: https://eslint.style/
+        '@stylistic/js',
         // eslint-plugin-header validates copyright header
         'header'
     ],
@@ -24,7 +33,11 @@ module.exports = {
     // we turn ON all of eslint rules by extending eslint:all
     // we selectively override the rules we want to remove or change.
     // See http://eslint.org/docs/user-guide/configuring#using-eslintall
-    extends: 'eslint:all',
+
+    extends: [
+        'eslint:all',
+        'plugin:@stylistic/js/all-extends',
+    ],
 
     rules: {
 
@@ -49,17 +62,18 @@ module.exports = {
 
         // verify every file contains our copyright header
         'header/header': ['error', 'block', [{
-            template: " Copyright (C) 2020 NooBaa ",
+            template: ` Copyright (C) ${CURRENT_YEAR} NooBaa `,
             pattern: " Copyright \\(C\\) 20\\d{2} NooBaa ",
         }]],
 
         // arrow function styling is not a real error but should be consistent
-        'arrow-parens': ['error', 'as-needed'],
+        '@stylistic/js/arrow-parens': ['error', 'as-needed'],
 
-        'brace-style': ['error', '1tbs', { allowSingleLine: true }],
+        // See: https://eslint.org/docs/latest/rules/brace-style
+        '@stylistic/js/brace-style': ['error', '1tbs', { allowSingleLine: true }],
 
         // maximum number of code paths in a function
-        // TODO eslint complexity should be reduced to ~10 instead of 30
+        // TODO eslint complexity should be reduced to ~10 instead of 35
         'complexity': ['error', 35],
 
         // must use self=this and not any other alternatives
@@ -69,10 +83,10 @@ module.exports = {
         'curly': ['error', 'multi-line'],
 
         // when splitting "obj.property" to 2 lines the dot should stick to the property
-        'dot-location': ['error', 'property'],
+        '@stylistic/js/dot-location': ['error', 'property'],
 
         // match generator-star-spacing to the beautifier preference
-        'generator-star-spacing': ['error', { before: false, after: true }],
+        '@stylistic/js/generator-star-spacing': 'off',
 
         // max depth of blocks in a function
         // TODO eslint max-depth of blocks should be reduced to ~3 instead of 5
@@ -88,50 +102,50 @@ module.exports = {
         'max-lines-per-function': ['error', 400],
 
         // prefer small number of params to functions, otherwise send object
-        // TODO eslint max-params per function should be reduced to ~4 instead of 6
+        // TODO eslint max-params per function should be reduced to ~4 instead of 7
         'max-params': ['error', 7],
 
         // max statements in function
         // TODO eslint max-statements per function should be reduced to ~40 instead of 60
         'max-statements': ['error', 60],
 
-        'newline-per-chained-call': ['error', { ignoreChainWithDepth: 4 }],
+        '@stylistic/js/newline-per-chained-call': ['error', { ignoreChainWithDepth: 4 }],
 
         // don't assign inside a condition, separate the lines for clarity
         'no-cond-assign': ['error', 'always'],
 
-        'no-confusing-arrow': ['error', { allowParens: true }],
+        '@stylistic/js/no-confusing-arrow': ['error', { allowParens: true }],
 
         // empty lines are mostly harmless
-        'no-multiple-empty-lines': ['error', { max: 20 }],
+        '@stylistic/js/no-multiple-empty-lines': ['error', { max: 20 }],
 
         // don't allow the code to leave unused variables, this prevents typos in many cases
         'no-unused-vars': ['error', { vars: 'all', args: 'none' }],
 
         // don't use assignments inside return statements, use separate statements.
         'no-return-assign': ['error', 'always'],
 
-        'no-trailing-spaces': ['error', { ignoreComments: true }],
+        '@stylistic/js/no-trailing-spaces': ['error', { ignoreComments: true }],
 
         // do not allow code using variables before they are defined and initialized,
         // but ok for functions since function decelerations are loaded before the code runs
         'no-use-before-define': ['error', 'nofunc'],
 
         // break lines after operators, not before
-        'operator-linebreak': ['error', 'after'],
+        '@stylistic/js/operator-linebreak': ['error', 'after'],
 
         // we prefer single var statement per variable
         'one-var': ['error', 'never'],
 
-        'space-before-function-paren': ['error', {
+        '@stylistic/js/space-before-function-paren': ['error', {
             'anonymous': 'never',
             'named': 'never',
             'asyncArrow': 'always'
         }],
 
-        'function-call-argument-newline': 'off',
+        '@stylistic/js/function-call-argument-newline': 'off',
 
-        'space-unary-ops': ['error', {
+        '@stylistic/js/space-unary-ops': ['error', {
             words: true,
             nonwords: false,
             overrides: {
@@ -141,7 +155,7 @@ module.exports = {
 
         // max line length is 80 by default, allow some slack
         // TODO eslint max-len for code lines should be error and reduced to ~100 instead of 140
-        'max-len': ['error', {
+        '@stylistic/js/max-len': ['error', {
             code: 140,
             tabWidth: 4,
             ignoreComments: true,
@@ -161,6 +175,11 @@ module.exports = {
         // instead of expression (foo = function() {})
         'func-style': ['error', 'declaration', { allowArrowFunctions: true }],
 
+        "prefer-const": ["error", {
+            "destructuring": "all",
+            "ignoreReadBeforeAssign": false
+        }],
+
         //////////////////////////////////////////////////////////////////////
         //                                                                  //
         // WARN                                                             //
@@ -182,9 +201,9 @@ module.exports = {
 
 
         // not forcing how arrays should have new-line breaks
-        'array-element-newline': 'off',
-        'array-bracket-newline': 'off',
-        'array-bracket-spacing': 'off',
+        '@stylistic/js/array-element-newline': 'off',
+        '@stylistic/js/array-bracket-newline': 'off',
+        '@stylistic/js/array-bracket-spacing': 'off',
 
         // camelcase is a religion. we were born differently.
         'camelcase': 'off',
@@ -202,45 +221,42 @@ module.exports = {
         'class-methods-use-this': 'off',
 
         // dangling commas are great for arrays and object properties
-        'comma-dangle': 'off',
+        '@stylistic/js/comma-dangle': 'off',
 
         // consistent return does not allow to write promises code very easily
         // because in many cases there are conditions to running a promise,
         // and otherwise the expected behavior is to simply continue.
         'consistent-return': 'off',
 
-        // ending files with single EOL is overrated
-        'eol-last': 'off',
-
         // allowing anonymous functions, used a lot for promises
         'func-names': 'off',
 
         // not forcing a consistent policy on line breaks inside func parentheses
-        'function-paren-newline': 'off',
+        '@stylistic/js/function-paren-newline': 'off',
 
         // allow short variable names like '_' or 'P' etc. use with care.
         'id-length': 'off',
 
-        'implicit-arrow-linebreak': ['off', 'beside'],
+        '@stylistic/js/implicit-arrow-linebreak': ['off', 'beside'],
 
         // indent of 4 spaces would be good to enforce, but it doesn't work well for promise chains
         // so hope no-mixed-spaces-and-tabs will be good enough
-        'indent': ['off', 4],
+        '@stylistic/js/indent': ['off', 4],
 
         // not forcing initialization of variables
         'init-declarations': 'off',
 
         // directive means 'use strict', we don't enforce lines around
         'lines-around-directive': 'off',
-        'lines-around-comment': 'off',
-        'lines-between-class-members': 'off',
+        '@stylistic/js/lines-around-comment': 'off',
+        '@stylistic/js/lines-between-class-members': 'off',
 
         // we don't enforce comments to above/after the line, both work ok
         'line-comment-position': 'off',
 
         // ternary operator is better split to 3 lines for readability
         // TODO eslint multiline-ternary should be error
-        'multiline-ternary': 'off',
+        '@stylistic/js/multiline-ternary': 'off',
 
         // use any comment style, just write comments
         'multiline-comment-style': 'off',
@@ -260,7 +276,7 @@ module.exports = {
         // avoid redundant 'else' when using return statements in all cases
         'no-else-return': 'off',
 
-        'no-extra-parens': ['off', 'all', { nestedBinaryExpressions: false }],
+        '@stylistic/js/no-extra-parens': ['off', 'all', { nestedBinaryExpressions: false }],
 
         // short comments in-line are not great but sometimes make a lot of sense
         'no-inline-comments': 'off',
@@ -287,33 +303,27 @@ module.exports = {
         // we do allow _name or name_ as identifiers
         'no-underscore-dangle': 'off',
 
-        // prefer to use let/const instead of var
-        'no-var': 'off',
-
         // turn off todo/fixme comments - will grep it to a different report
         'no-warning-comments': 'off',
 
         // the rule object-property-newline is better than object-curly-newline
-        'object-property-newline': 'off',
-        'object-curly-newline': 'off',
+        '@stylistic/js/object-property-newline': 'off',
+        '@stylistic/js/object-curly-newline': 'off',
 
-        'object-curly-spacing': 'off',
+        '@stylistic/js/object-curly-spacing': 'off',
 
         // prefer using x={a,b} over x={a:a, b:b} but too much to fix
         'object-shorthand': 'off',
 
         // ignore stylish padding code blocks with newlines
-        'padded-blocks': 'off',
+        '@stylistic/js/padded-blocks': 'off',
 
         // prefer using arrow functions for callbacks, but too much to fix
         'prefer-arrow-callback': 'off',
 
         // prefer using arrow functions for callbacks, but too much to fix
         'prefer-named-capture-group': 'off',
 
-        // we prefer using const, but too much to fix
-        'prefer-const': 'off',
-
         // we prefer using destructuring, but too much to fix
         'prefer-destructuring': 'off',
 
@@ -325,11 +335,11 @@ module.exports = {
         'prefer-template': 'off',
 
         // prefer using single quotes, but too much to fix
-        'quotes': ['off', 'single'],
+        '@stylistic/js/quotes': ['off', 'single'],
 
-        'quote-props': 'off',
+        '@stylistic/js/quote-props': 'off',
         'require-jsdoc': 'off',
-        'spaced-comment': 'off',
+        '@stylistic/js/spaced-comment': 'off',
         'sort-keys': 'off',
 
         // don't verify the structure of jsdoc comments. let them be for now.
@@ -346,5 +356,10 @@ module.exports = {
 
         'no-promise-executor-return': 'off',
 
+        //Allow spacing between template tags and their literals
+        '@stylistic/js/template-tag-spacing': 'off',
+
+        // we prefer not to adopt the logical assignment operators from ES2020
+        'logical-assignment-operators': 'off'
     }
 };

.github/stale.yml

@@ -0,0 +1,17 @@
+# Number of days of inactivity before an issue becomes stale
+daysUntilStale: 1095
+# Number of days of inactivity before a stale issue is closed
+daysUntilClose: 14
+# Issues with these labels will never be considered stale
+exemptLabels:
+  - "Type:Enhancement"
+  - "Type: Technical Debt"
+# Label to use when marking an issue as stale
+staleLabel: "Closed Won't Fix"
+# Comment to post when marking an issue as stale. Set to `false` to disable
+markComment: >
+  This issue has been automatically marked as stale because it has not had
+  recent activity. It will be closed if no further activity occurs. Thank you
+  for your contributions.
+# Comment to post when closing a stale issue. Set to `false` to disable
+closeComment: false