Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept unfinalized readonly classes #43

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Accept unfinalized readonly classes #43

merged 2 commits into from
Sep 6, 2024

Conversation

niji-mneute
Copy link
Contributor

I made this pull request to accept readonly classes, for instance this class is detected as non-final by the command but nothing's changed :

<?php
readonly class MyAwesomeClass {
}

niji-ahubert
niji-ahubert suggested changes Sep 6, 2024
View reviewed changes
Copy link

@niji-ahubert niji-ahubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps some test

@niji-mneute
Copy link
Contributor Author

Like this ?

@TomasVotruba
Copy link
Member

Looks good, thank you @niji-ahubert 👏

@TomasVotruba TomasVotruba merged commit 93890b0 into rectorphp:main Sep 6, 2024
8 checks passed
@niji-mneute niji-mneute deleted the readonly-classes branch September 6, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niji-ahubert niji-ahubert niji-ahubert requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niji-mneute @TomasVotruba @niji-ahubert