Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FinalizeClasses: support for @final annotation #20

Closed
wants to merge 1 commit into from
Closed

FinalizeClasses: support for @final annotation #20

wants to merge 1 commit into from

Conversation

gnutix
Copy link
Contributor

@gnutix gnutix commented Apr 4, 2024 •
edited
Loading

TODO

@gnutix gnutix force-pushed the finalize-classes-annotation-support branch 2 times, most recently from 8252798 to 4085f84 Compare April 4, 2024 08:03
This was referenced Apr 4, 2024
Closed
Merged
@gnutix gnutix force-pushed the finalize-classes-annotation-support branch from 4085f84 to c765731 Compare April 4, 2024 08:35
@gnutix gnutix force-pushed the finalize-classes-annotation-support branch from c765731 to 2b258d3 Compare April 11, 2024 14:40
@TomasVotruba
Copy link
Member

Hi, thanks for proposal.

Looking into this again and it woud not be based on native PHP. Using @final only hides some logic that should be revealed explicitly, e.g. entities defined with attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnutix @TomasVotruba