misc

rectorphp · Sep 6, 2024 · 32425e8 · 32425e8
1 parent 37bca44
commit 32425e8
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/src/Command/PrivatizeConstantsCommand.php b/src/Command/PrivatizeConstantsCommand.php
@@ -13,6 +13,7 @@
 use Rector\SwissKnife\PhpParser\ClassConstantFetchFinder;
 use Rector\SwissKnife\PhpParser\NodeTraverserFactory;
 use Rector\SwissKnife\PhpParser\NodeVisitor\FindNonPrivateClassConstNodeVisitor;
+use Rector\SwissKnife\ValueObject\ClassConstant;
 use Rector\SwissKnife\ValueObject\ClassConstantFetch\CurrentClassConstantFetch;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputArgument;
@@ -117,7 +118,9 @@ private function processFileInfo(SplFileInfo $phpFileInfo, array $classConstantF
 
                 FileSystem::write($phpFileInfo->getRealPath(), $changedFileContents);
 
-                $this->symfonyStyle->note(sprintf('Constant %s changed to public', $classConstant->getConstantName()));
+                $this->symfonyStyle->note(
+                    sprintf('Constant "%s" changed to public', $classConstant->getConstantName())
+                );
                 continue;
             }
 
@@ -129,19 +132,21 @@ private function processFileInfo(SplFileInfo $phpFileInfo, array $classConstantF
             );
             FileSystem::write($phpFileInfo->getRealPath(), $changedFileContents);
 
-            $this->symfonyStyle->note(sprintf('Constant %s changed to private', $classConstant->getConstantName()));
+            $this->symfonyStyle->note(sprintf('Constant "%s" changed to private', $classConstant->getConstantName()));
         }
     }
 
-    private function isClassConstantUsedPublicly(
-        array $classConstantFetches,
-        \Rector\SwissKnife\ValueObject\ClassConstant $classConstant
-    ): bool {
+    /**
+     * @param ClassConstantFetchInterface[] $classConstantFetches
+     */
+    private function isClassConstantUsedPublicly(array $classConstantFetches, ClassConstant $classConstant): bool
+    {
         foreach ($classConstantFetches as $classConstantFetch) {
             if (! $classConstantFetch->isClassConstantMatch($classConstant)) {
                 continue;
             }
 
+            // used only locally, can stay private
             if ($classConstantFetch instanceof CurrentClassConstantFetch) {
                 continue;
             }