[READWISE] RxDB patch #17
Conversation
eliias
force-pushed
the
hannes/readwise-2
branch
14 times, most recently
from
deb0fcd
to
c2e2bd1
Compare
eliias
force-pushed
the
hannes/readwise-2
branch
7 times, most recently
from
401323e
to
368a98c
Compare
eliias
force-pushed
the
hannes/readwise-2
branch
2 times, most recently
from
41b95b3
to
a7b0237
Compare
| @@ -27,6 +32,12 @@ export declare class RxQueryBase<RxDocType, RxQueryResult, OrmMethods = {}, Reac | |||
| _latestChangeEvent: -1 | number; | |||
| _lastExecStart: number; | |||
| _lastExecEnd: number; | |||
| _limitBufferSize: number | null; | |||
| _limitBufferResults: RxDocumentData<RxDocType>[] | null; | |||
| _persistentQueryCacheResult?: string[] | string; | |||
There was a problem hiding this comment.
i hope this stuff wasn't a hassle to carry over lol. given we don't use it rn
| @@ -112,6 +125,48 @@ export function getQueryParams<RxDocType>( | |||
| ); | |||
| } | |||
|
|
|||
| // This catches a specific case where we have a limit query (of say LIMIT items), and then | |||
There was a problem hiding this comment.
ooc have you tested to confirm the limit buffer stuff works? i guess we have tests for it
There was a problem hiding this comment.
I did not test anything tbh. I just rebased everything we had into a single commit and then resolved the merge conflicts. I think this comment is from last year :-).
There was a problem hiding this comment.
ya it is. just seeing the limit buffer code reminded me that we need to make sure that still works. it's all my custom code to make rxdb faster
There was a problem hiding this comment.
Yeah I can test more, there was nothing obvious that broke so far though and the code is/was pretty similar still in rx-query (and therefore I somewhat assume event-reduce to behave similar).
|
should this PR be into the |
@TristanH yeah I was wondering how you wanna deal with this rxdb15 upgrade. should we do readwise15 or we comfy with just reusing readwise? |
Yep, this PR includes all our changes against master, it was impossible to rebase all our commits against 1000+ rxdb commits (impossible = infinitely more work). |
|
hmm ok, well i guess i worry about merging into we could rename the old branch to |
|
back to the original (separate) question, i wish i had a way to review the actual changes, but i see why that's probably not doable here... will just cross reference with our old code |
|
ok @eliias reviewed it mostly, is there anywhere (i assume rx-query.ts) i should really look relevant to your changes? |
There are no real changes tbh, this was a rebase exercise. I don't know how to improve the review experience beyond what we have here, but I was hoping you remember your changes and I remember mine, and if we agree it does the same as before, we are good to ship. |
eliias
force-pushed
the
hannes/readwise-2
branch
2 times, most recently
from
610d410
to
c2f3dc8
Compare
This PR contains:
Describe the problem you have without this PR
Todos