-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing Blocking call for handlePossibleCancellationInterrupt #3515
Allowing Blocking call for handlePossibleCancellationInterrupt #3515
Conversation
...or-core/src/blockHoundTest/java/reactor/core/scheduler/ReactorBlockHoundIntegrationTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the test should not be touched at all. ReactorBlockHoundIntegration
it selves has to be edited with proposed change
allowBlockingCallsInside("java.util.concurrent.FutureTask",
"handlePossibleCancellationInterrupt")
@OlegDokuka I have reverted the test changes. |
@@ -1,5 +1,5 @@ | |||
/* | |||
* Copyright (c) 2019-2022 VMware Inc. or its affiliates, All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should also be reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @OlegDokuka reverted this change
@@ -50,5 +50,7 @@ public void applyTo(BlockHound.Builder builder) { | |||
// For now, let's not add a separate integration, but rather let's define the class name manually | |||
// ContextRegistry reads files as part of the Service Loader aspect. If class is initialized in a non-blocking thread, BlockHound would complain | |||
builder.allowBlockingCallsInside("reactor.core.publisher.ContextPropagation", "<clinit>"); | |||
builder.allowBlockingCallsInside("java.util.concurrent.FutureTask", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use FutureTask.class.getName()
instead of "java.util.concurrent.FutureTask"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update with class reference
This reverts commit c7cdc0a.
I've made required changes. @OlegDokuka please check |
@tejavenkatlanka great job! Thank you for your contribution! |
fixs #3512