This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
Force UTF-8 encoding on service parameter #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Do you happen to have an example URL that triggers the actual problem? |
|
Here's an example of recent one, but it looks like the non UTF-8 character has already been scrubbed here (this is from the Errbit report): |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using CAS in gateway mode and are experiencing errors when the original URL of the client application includes invalid UTF-8 characters. These are not "legitimate" user requests, but they happen a lot so it would be nice to prevent the error reports.
Here's part of a backtrace:
activesupport-3.2.19/lib/active_support/core_ext/object/blank.rb:105→ =~
activesupport-3.2.19/lib/active_support/core_ext/object/blank.rb:105→ !~
activesupport-3.2.19/lib/active_support/core_ext/object/blank.rb:105→ blank?
casino-2.0.4/app/processors/casino/processor_concern/service_tickets.rb:30→ clean_service_url
casino-2.0.4/app/processors/casino/login_credential_requestor_processor.rb:54→ check_service_allowed
casino-2.0.4/app/processors/casino/login_credential_requestor_processor.rb:22→ process
casino-2.0.4/app/controllers/casino/sessions_controller.rb:10→ new