Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Documentation and Automate SDK Releases [release] 2.0.16 #342

Merged
merged 3 commits into from
Jul 14, 2023

Conversation

DhanushReddy-2513
Copy link
Contributor

Release Date: 2023-07-13
RBI Update Date: 2023-06-30
IFSC Count: 167820
Diff Size: 402 (This only counts new or deleted IFSCs from previous release)

  • Metadata updates
  • Automated SDK Releases
  • Added Documentation
Aggregate Breakdown
-1  	IBKL
+1  	AUBL
+1  	BKID
+1  	IDIB
+1  	IOBA
+1  	NESF
+1  	PSIB
+1  	SDCB
+1  	UCBA
+1  	UNBA
+2  	DCBL
+2  	KVBL
+3  	CNRB
+3  	TMBL
+3  	YESB
+4  	IDFB
+4  	RATN
+5  	BARB
+5  	GSCB
+5  	PUNB
+7  	COSB
+8  	KKBK
+9  	UBIN
+10 	UJVN
+11 	INDB
+12 	FDRL
+21 	SBIN
+30 	MAHB
+34 	HDFC
+38 	UTIB
+44 	BUCB
+45 	ICIC
+73 	BDBL
Exact IFSC Diff
+AUBL00CCUPI
+BARB0CMSVBA
+BARB0CMSVBB
+BARB0CMSVBC
+BARB0CMSVBD
+BARB0KTPULI
+BDBL0002243
+BDBL0002274
+BDBL0002332
+BDBL0002338
+BDBL0002349
+BDBL0002367
+BDBL0002388
+BDBL0002390
+BDBL0002397
+BDBL0002406
+BDBL0002407
+BDBL0002411
+BDBL0002416
+BDBL0002421
+BDBL0002427
+BDBL0002431
+BDBL0002437
+BDBL0002439
+BDBL0002444
+BDBL0002445
+BDBL0002446
+BDBL0002447
+BDBL0002450
+BDBL0002453
+BDBL0002457
+BDBL0002459
+BDBL0002468
+BDBL0002478
+BDBL0002482
+BDBL0002486
+BDBL0002493
+BDBL0002495
+BDBL0002500
+BDBL0002502
+BDBL0002503
+BDBL0002504
+BDBL0002507
+BDBL0002513
+BDBL0002524
+BDBL0002528
+BDBL0002530
+BDBL0002531
+BDBL0002536
+BDBL0002537
+BDBL0002538
+BDBL0002543
+BDBL0002544
+BDBL0002548
+BDBL0002549
+BDBL0002555
+BDBL0002556
+BDBL0002557
+BDBL0002558
+BDBL0002559
+BDBL0002562
+BDBL0002563
+BDBL0002566
+BDBL0002570
+BDBL0002577
+BDBL0002579
+BDBL0002581
+BDBL0002583
+BDBL0002584
+BDBL0002586
+BDBL0002587
+BDBL0002588
+BDBL0002589
+BDBL0002596
+BDBL0002601
+BDBL0002604
+BDBL0002605
+BDBL0002606
+BDBL0002611
+BKID000JSMF
+BUCB0000001
+BUCB00000SC
+BUCB0000100
+BUCB0000101
+BUCB0000102
+BUCB0000103
+BUCB0000104
+BUCB0000105
+BUCB0000106
+BUCB0000107
+BUCB0000108
+BUCB0000109
+BUCB0000110
+BUCB0000111
+BUCB0000112
+BUCB0000113
+BUCB0000114
+BUCB0000115
+BUCB0000116
+BUCB0000117
+BUCB0000118
+BUCB0000119
+BUCB0000120
+BUCB0000121
+BUCB0000122
+BUCB0000123
+BUCB0000124
+BUCB0000125
+BUCB0000126
+BUCB0000127
+BUCB0000128
+BUCB0000129
+BUCB0000130
+BUCB0000131
+BUCB0000132
+BUCB0000133
+BUCB0000134
+BUCB0000135
+BUCB0000136
+BUCB0000137
+BUCB0000138
+BUCB0000139
+BUCB0000140
+BUCB0000141
+CNRB0007287
+CNRB0007357
+CNRB0007370
+COSB0000140
+COSB0000141
+COSB0000142
+COSB0000143
+COSB0000144
+COSB0000145
+COSB0000146
+DCBL0000465
+DCBL0000466
+FDRL0002423
+FDRL0002431
+FDRL0002432
+FDRL0002434
+FDRL0002435
+FDRL0002437
+FDRL0002440
+FDRL0002441
+FDRL0002446
+FDRL0002447
+FDRL0002448
+FDRL0002455
+FDRL0007507
+GSCB0UMA002
+GSCB0UMA003
+GSCB0UMA004
+GSCB0UMA005
+GSCB0UMA006
+HDFC0005102
+HDFC0005743
+HDFC0005759
+HDFC0005865
+HDFC0005909
+HDFC0006000
+HDFC0006359
+HDFC0006370
+HDFC0006450
+HDFC0006452
+HDFC0007015
+HDFC0007024
+HDFC0007026
+HDFC0007196
+HDFC0007197
+HDFC0007223
+HDFC0007258
+HDFC0007272
+HDFC0007280
+HDFC0007408
+HDFC0007473
+HDFC0007517
+HDFC0007538
+HDFC0007742
+HDFC0007988
+HDFC0008132
+HDFC0008198
+HDFC0008228
+HDFC0008229
+HDFC0008255
+HDFC0008349
+HDFC0008357
+HDFC0008410
+HDFC0008665
+HDFC0008700
+HDFC0008862
+HDFC0008957
+ICIC0004776
+ICIC0004877
+ICIC0004891
+ICIC0004931
+ICIC0004946
+ICIC0005261
+ICIC0005293
+ICIC0005295
+ICIC0005312
+ICIC0005324
+ICIC0005328
+ICIC0005329
+ICIC0005330
+ICIC0005331
+ICIC0005346
+ICIC0005347
+ICIC0005351
+ICIC0005357
+ICIC0005367
+ICIC0005370
+ICIC0005373
+ICIC0005376
+ICIC0005378
+ICIC0005388
+ICIC0005391
+ICIC0005398
+ICIC0005399
+ICIC0005410
+ICIC0005413
+ICIC0005417
+ICIC00BUCBL
+ICIC00ZSKT3
+ICIC00ZSKT7
+ICIC0ZSKT10
+ICIC0ZSKT11
+ICIC0ZSKT12
+ICIC0ZSKT13
+ICIC0ZSKT15
+ICIC0ZSKT16
+ICIC0ZSKT19
+ICIC0ZSKT21
+ICIC0ZSKT27
+ICIC0ZSKT28
+ICIC0ZSKT32
+ICIC0ZSKT33
+IDFB0020229
+IDFB0041387
+IDFB0060135
+IDFB0080243
+IDIB000B216
+INDB0002155
+INDB0002168
+INDB0002169
+INDB0002184
+INDB0002185
+INDB0002189
+INDB0002195
+INDB0002203
+INDB0002205
+INDB0002206
+INDB0002208
+IOBA0003815
+KKBK0001494
+KKBK0001495
+KKBK0002109
+KKBK0002617
+KKBK0004120
+KKBK0004674
+KKBK0005978
+KKBK0008400
+KVBL0004923
+KVBL0004924
+MAHB0002373
+MAHB0002374
+MAHB0002396
+MAHB0002397
+MAHB0002398
+MAHB0002399
+MAHB0002400
+MAHB0002401
+MAHB0002402
+MAHB0002403
+MAHB0002404
+MAHB0002405
+MAHB0002407
+MAHB0002414
+MAHB0002415
+MAHB0002416
+MAHB0002422
+MAHB0002424
+MAHB0002425
+MAHB0002426
+MAHB0002427
+MAHB0002428
+MAHB0002429
+MAHB0002430
+MAHB0002431
+MAHB0002432
+MAHB0002433
+MAHB0002434
+MAHB0002435
+MAHB0002436
+NESF0000217
+PSIB0021608
+PUNB0947200
+PUNB0956600
+PUNB0956800
+PUNB0957200
+PUNB0957600
+RATN0000539
+RATN0000540
+RATN0000541
+RATN0000546
+SBIN0062122
+SBIN0064197
+SBIN0064198
+SBIN0064221
+SBIN0064224
+SBIN0064321
+SBIN0064322
+SBIN0064375
+SBIN0064383
+SBIN0064385
+SBIN0064386
+SBIN0064388
+SBIN0064390
+SBIN0080076
+SBIN0080089
+SBIN0080091
+SBIN0080093
+SBIN0080111
+SBIN0080112
+SBIN0080113
+SBIN0080115
+SDCB0000120
+TMBL0000536
+TMBL0000537
+TMBL0000538
+UBIN0579041
+UBIN0579386
+UBIN0579475
+UBIN0579530
+UBIN0579840
+UBIN0579980
+UBIN0580473
+UBIN0585866
+UBIN0590045
+UCBA0003533
+UJVN0003644
+UJVN0003647
+UJVN0003651
+UJVN0003657
+UJVN0003660
+UJVN0003661
+UJVN0004528
+UJVN0004531
+UJVN0004544
+UJVN0004550
+UNBA0000521
+UTIB0005184
+UTIB0005185
+UTIB0005187
+UTIB0005191
+UTIB0005196
+UTIB0005200
+UTIB0005204
+UTIB0005207
+UTIB0005209
+UTIB0005210
+UTIB0005211
+UTIB0005212
+UTIB0005213
+UTIB0005215
+UTIB0005216
+UTIB0005217
+UTIB0005218
+UTIB0005220
+UTIB0005221
+UTIB0005222
+UTIB0005223
+UTIB0005224
+UTIB0005229
+UTIB0005231
+UTIB0005232
+UTIB0005233
+UTIB0005234
+UTIB0005237
+UTIB0005240
+UTIB0005241
+UTIB0005244
+UTIB0005257
+UTIB0005268
+UTIB0005269
+UTIB0005270
+UTIB0005278
+UTIB0SGB001
+UTIB0UUCB01
+YESB0001387
+YESB0001389
+YESB0001390
+YESB0001394
+YESB0001396
+YESB0001398
-FDRL0SAWANT
-HDFC0CDJMCB
-HDFC0CRCUB1
-HDFC0CVSVCB
-IBKL0579RSB
-YESB0VSV002
-YESB0VSV003
-YESB0VSV004

@DhanushReddy-2513 DhanushReddy-2513 added the TestingNotRequired TestingNotRequired label for BVT label Jul 13, 2023
Copy link

@krishnamraj krishnamraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address the comments

DOCUMENTATION.md Outdated
@@ -0,0 +1,70 @@
## Check whether a new release is required
1. Whenever a change in detected on the RBI website (https://rbi.org.in/), an automated email from the "RBI Updates" is sent on the "#tech_ifsc" Slack channel.
2. Open the website it has detected change and check the RBI release date to see if a new release is needed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What to check to identify whether new release is required?

DOCUMENTATION.md Outdated
7. Extract the artifacts and copy the files `banks.json`, `IFSC.json` and `sublet.json` into the `ifsc/src/` directory.
8. Again, commit these changes and push it into the IFSC repository and check the tests. If something is failing, you might need to edit the constants or `banknames.json` file.
9. Create a new pull request with this branch. Copy the `release-notes.md` file and use that as description for the PR. Review and merge the PR. Tag the merge commit (don't use a prefix, just `X.Y.Z`).
10. Push the tag to GitHub.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewrite it as "Create a new release (Ref: link)"

  • Create new tag with pattern vx.y.z e.g. v2.0.14
  • Use release-notes.md file as the template
  • Replace TODO as applicable for the release.
  • Upload the release-artifact files as part of the release

DOCUMENTATION.md Outdated
7. Check whether the ifsc gem is updated to the latest version (`grep ifsc Gemfile.lock`).
8. Commit this as `[release] x.y.z`. Push these changes to the IFSC-API repository (https://github.com/razorpay/ifsc-api).
9. Create a new pull request with this branch. Review and merge the PR. Tag the merge commit (don't use a prefix, just `X.Y.Z`).
10. Push the tag to GitHub.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewrite as discussed above

6. Merge and deploy.

## Deploy the new IFSC release on the API website (https://ifsc.razorpay.com/)
1. Go to Spinnaker (https://deploy.razorpay.com/#/applications/stage-ifsc/executions).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stage deployment

@DhanushReddy-2513 DhanushReddy-2513 merged commit 42ed545 into master Jul 14, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TestingNotRequired TestingNotRequired label for BVT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants