-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Documentation and Automate SDK Releases [release] 2.0.16 #342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address the comments
DOCUMENTATION.md
Outdated
@@ -0,0 +1,70 @@ | |||
## Check whether a new release is required | |||
1. Whenever a change in detected on the RBI website (https://rbi.org.in/), an automated email from the "RBI Updates" is sent on the "#tech_ifsc" Slack channel. | |||
2. Open the website it has detected change and check the RBI release date to see if a new release is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What to check to identify whether new release is required?
DOCUMENTATION.md
Outdated
7. Extract the artifacts and copy the files `banks.json`, `IFSC.json` and `sublet.json` into the `ifsc/src/` directory. | ||
8. Again, commit these changes and push it into the IFSC repository and check the tests. If something is failing, you might need to edit the constants or `banknames.json` file. | ||
9. Create a new pull request with this branch. Copy the `release-notes.md` file and use that as description for the PR. Review and merge the PR. Tag the merge commit (don't use a prefix, just `X.Y.Z`). | ||
10. Push the tag to GitHub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rewrite it as "Create a new release (Ref: link)"
- Create new tag with pattern vx.y.z e.g. v2.0.14
- Use
release-notes.md
file as the template - Replace
TODO
as applicable for the release. - Upload the
release-artifact
files as part of the release
DOCUMENTATION.md
Outdated
7. Check whether the ifsc gem is updated to the latest version (`grep ifsc Gemfile.lock`). | ||
8. Commit this as `[release] x.y.z`. Push these changes to the IFSC-API repository (https://github.com/razorpay/ifsc-api). | ||
9. Create a new pull request with this branch. Review and merge the PR. Tag the merge commit (don't use a prefix, just `X.Y.Z`). | ||
10. Push the tag to GitHub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rewrite as discussed above
6. Merge and deploy. | ||
|
||
## Deploy the new IFSC release on the API website (https://ifsc.razorpay.com/) | ||
1. Go to Spinnaker (https://deploy.razorpay.com/#/applications/stage-ifsc/executions). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stage deployment
Release Date:
2023-07-13
RBI Update Date:
2023-06-30
IFSC Count: 167820
Diff Size: 402 (This only counts new or deleted IFSCs from previous release)
Aggregate Breakdown
Exact IFSC Diff