RDBC-864 Node.js client bulk insert performance

[ml054]

https://issues.hibernatingrhinos.com/issue/RDBC-864/Node.js-client-bulk-insert-performance

[ayende]

I think that this._asyncWriteDone should be in isFlushNeeded

[ml054]

yes. It generates more falses in tryStoreSync, but we wait less overall.

[ayende]

isFlushNeeded, no?

[ml054]

no, first guarantees that stream was ensured and it was initialized.

[ayende]

Suggested change

	private isFlashNeeded(): boolean {
	private isFlushNeeded(): boolean {

[ayende]

Trying to run with this gives me:

  [cause]: ReferenceError: fetch is not defined
      at eu.send (C:\Work\tmp\node_modules\ravendb\dist\cjs\ravendb.cjs:5:4667)
      at o._send (C:\Work\tmp\node_modules\ravendb\dist\cjs\ravendb.cjs:5:44540)
      at async o._sendRequestToServer (C:\Work\tmp\node_modules\ravendb\dist\cjs\ravendb.cjs:5:43256)
      at async o._executeOnSpecificNode (C:\Work\tmp\node_modules\ravendb\dist\cjs\ravendb.cjs:5:41974)
      at async o._handleServerDown (C:\Work\tmp\node_modules\ravendb\dist\cjs\ravendb.cjs:5:51434)
      at async o._sendRequestToServer (C:\Work\tmp\node_modules\ravendb\dist\cjs\ravendb.cjs:5:44316)
      at async o._executeOnSpecificNode (C:\Work\tmp\node_modules\ravendb\dist\cjs\ravendb.cjs:5:41974)
      at async bs._getNextRange (C:\Work\tmp\node_modules\ravendb\dist\cjs\ravendb.cjs:10:28284)
      at async bs.getNextId (C:\Work\tmp\node_modules\ravendb\dist\cjs\ravendb.cjs:10:28051)
      at async bs.generateDocumentId (C:\Work\tmp\node_modules\ravendb\dist\cjs\ravendb.cjs:10:27699)

• checked out v6.0
• pulled your changes
• npm run build, npm pack
• npm i /path/to/ravendb-6.0.0.tgz

 const store = new DocumentStore('http://localhost:8080', 'bulk');
    store.initialize();
    const bulk = store.bulkInsert();
    for (let i = 0; i < 100_000_000; i++) {
        const user = new User('user' + i);
        const id = "users/" + i;
        if (bulk.tryStoreSync(user, id) == false) {
            await bulk.store(user, id);
        }
    }
    console.log('done storing');
    await bulk.finish();

Tried with and without tryStoreAsync, same error.

[ayende]

When running in debug, it complains about missing ReadableStream and then about fetch.

$ node --version
v16.14.0

Upgraded to node v20 and it appears to be working

[ml054]

in 6.0 we require node.js 18+
https://github.com/ravendb/ravendb-nodejs-client/blob/v6.0/package.json#L40

however node 16 doesn't seem to respect this setting. :(