Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel: Define a minimal Bazel module #269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

egorich239
Copy link

This defines the very minimal integration with Bazel build system. The definitions follow the spirit of README.md in that the build rules package the library such that it can be included with

#include <spng.h>

This defines the very minimal integration with Bazel build system.
The definitions follow the spirit of README.md in that the build rules
package the library such that it can be included with

```c
```
compatibility_level = 1,
)

bazel_dep(name = "zlib", version = "1.3.1")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with bazel, does this specify 1.3.1 and only 1.3.1 or the minimum version?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If libspng is the only user of zlib in a bazel workspace, then it would mean 1.3.1 exactly.
If there is another bazel_dep with, say, zlib 1.3.2 in its dependencies, then

Full details:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants