Move token from the query strings to the session #210
+16
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christofdamian
force-pushed
the
session-tokens
branch
from
fec703c
to
79ec617
Compare
Slack stopped allowing tokens in query strings. See https://api.slack.com/changelog/2020-11-no-more-tokens-in-querystrings-for-newly-created-apps This moves the token handling into the request sessions object, which also cleans up the code a bit. Fixes randsleadershipslack#209
christofdamian
force-pushed
the
session-tokens
branch
from
79ec617
to
b82de9e
Compare
christofdamian
added a commit
to christofdamian/destalinator
that referenced
this pull request
Apr 14, 2021
Allow passing both the bot and user token to the scripts via the environment variables DESTALINATOR_API_BOT_TOKEN and DESTALINATOR_API_USER_TOKEN. They have different permissions and the bot token is only used to post messags, all other calls use the user token. Fixes randsleadershipslack#194. This also includes randsleadershipslack#210 and fixes randsleadershipslack#209 by moving the tokens into the header instead of using query parameters. Don't pass `as_user` to Slack, as this has been removed.
christofdamian
force-pushed
the
session-tokens
branch
from
3e0f48a
to
b82de9e
Compare
kmarekspartz
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack stopped allowing tokens in query strings.
See
https://api.slack.com/changelog/2020-11-no-more-tokens-in-querystrings-for-newly-created-apps
This moves the token handling into the request sessions object, which also
cleans up the code a bit.
Fixes #209
Caveat: I have no idea what I am doing and the code is failing in a different area for me now