Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack authentication tokens in query parameters don't work any more. #209

Open
christofdamian opened this issue Mar 19, 2021 · 0 comments · May be fixed by #210 or #211
Open

Slack authentication tokens in query parameters don't work any more. #209

christofdamian opened this issue Mar 19, 2021 · 0 comments · May be fixed by #210 or #211

Comments

@christofdamian
Copy link

https://api.slack.com/changelog/2020-11-no-more-tokens-in-querystrings-for-newly-created-apps

On February 24, 2021, we will stop allowing newly created Slack apps to send requests to Web API methods with access tokens presented in a URL query string. Instead, apps must send tokens in the Authorization HTTP header or alternatively as a URL-encoded POST body parameter.

Just when I finally want to try the destalinator!
christofdamian added a commit to christofdamian/destalinator that referenced this issue Mar 23, 2021
@christofdamian
Move token from the query strings to the session
fec703c 
Slack stopped allowing tokens in query strings.
See
https://api.slack.com/changelog/2020-11-no-more-tokens-in-querystrings-for-newly-created-apps

This moves the token handling into the request sessions object, which also
cleans up the code a bit.

Fixes randsleadershipslack#209
@christofdamian christofdamian linked a pull request Mar 23, 2021 that will close this issue
Open
christofdamian added a commit to christofdamian/destalinator that referenced this issue Mar 23, 2021
@christofdamian
Move token from the query strings to the session
79ec617 
Slack stopped allowing tokens in query strings.
See
https://api.slack.com/changelog/2020-11-no-more-tokens-in-querystrings-for-newly-created-apps

This moves the token handling into the request sessions object, which also
cleans up the code a bit.

Fixes randsleadershipslack#209
christofdamian added a commit to christofdamian/destalinator that referenced this issue Mar 23, 2021
@christofdamian
Move token from the query strings to the session
b82de9e 
Slack stopped allowing tokens in query strings.
See
https://api.slack.com/changelog/2020-11-no-more-tokens-in-querystrings-for-newly-created-apps

This moves the token handling into the request sessions object, which also
cleans up the code a bit.

Fixes randsleadershipslack#209
christofdamian added a commit to christofdamian/destalinator that referenced this issue Apr 14, 2021
@christofdamian
Use bot & user token for full functionality with newer bots
3e0f48a 
Allow passing both the bot and user token to the scripts via the environment
variables DESTALINATOR_API_BOT_TOKEN and DESTALINATOR_API_USER_TOKEN. They have
different permissions and the bot token is only used to post messags, all other
calls use the user token. Fixes randsleadershipslack#194.

This also includes randsleadershipslack#210 and fixes randsleadershipslack#209 by moving the tokens into the header
instead of using query parameters.

Don't pass `as_user` to Slack, as this has been removed.
@christofdamian christofdamian linked a pull request Apr 14, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@christofdamian