Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.10.0] Add docs for the new field RefreshInterval #1432

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rohitsakala
Copy link
Member

@rohitsakala rohitsakala commented Aug 19, 2024

Targeted for 2.10.0 release

@martyav
Copy link
Contributor

martyav commented Aug 19, 2024

@rohitsakala is this related to an upcoming release?

@rohitsakala rohitsakala marked this pull request as draft August 19, 2024 18:25
@rohitsakala
Copy link
Member Author

rohitsakala commented Aug 19, 2024

@martyav Yes This PR should be in Draft. I will change it to Ready to Review when it is ready.

Upcoming Release ? Yes. Not sure which one since this is a cross team effort

@rohitsakala rohitsakala marked this pull request as ready for review September 13, 2024 18:57
@martyav martyav changed the title Add docs for the new field RefreshInterval [v2.10.0] Add docs for the new field RefreshInterval Sep 13, 2024
@martyav martyav added this to the v2.10-Next1 milestone Sep 13, 2024
@@ -194,6 +194,16 @@ Non-Airgap Rancher installations upon refresh will reflect any chart repository

Airgap installations where Rancher is configured to use the packaged copy of Helm system charts ([`useBundledSystemChart=true`](../../../getting-started/installation-and-upgrade/other-installation-methods/air-gapped-helm-cli-install/install-rancher-ha.md#helm-chart-options-for-air-gap-installations)) will only refer to the [system-chart](https://github.com/rancher/system-charts) repository that comes bundled and will not be able to be refreshed or synced.

#### Refresh Interval

1. A new field `refreshInterval` has been added to the `ClusterRepo` CRD. The default `refreshInterval` is set to 3600 seconds and Rancher syncs the repository every 3600 seconds for each Helm repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. A new field `refreshInterval` has been added to the `ClusterRepo` CRD. The default `refreshInterval` is set to 3600 seconds and Rancher syncs the repository every 3600 seconds for each Helm repository.
Rancher v2.10.0 adds the `refreshInterval` field to the `ClusterRepo` CRD. The default value is 3600 seconds, meaning that Rancher syncs each Helm repository every 3600 seconds.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


To modify the refresh interval of a chart repository:

1. Find the repository you want to modify, and click **⋮ > Edit YAML**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should include instructions on accessing the list of repositories

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


1. Find the repository you want to modify, and click **⋮ > Edit YAML**.
1. Set the `refreshInterval` field under `Spec` to the desired value in seconds.
1. Click on **Save**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Click on **Save**.
1. Click **Save**.

Style guide advises against "Click on"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

To modify the refresh interval of a chart repository:

1. Find the repository you want to modify, and click **⋮ > Edit YAML**.
1. Set the `refreshInterval` field under `Spec` to the desired value in seconds.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Set the `refreshInterval` field under `Spec` to the desired value in seconds.
1. Set the **refreshInterval** field under **Spec** to the desired value in seconds.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants