Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Updated z-schema to v4.0.1 (adds support for circular references) #855

Merged
merged 1 commit into from
Apr 13, 2019
Merged

Updated z-schema to v4.0.1 (adds support for circular references) #855

merged 1 commit into from
Apr 13, 2019

Conversation

santam85
Copy link
Contributor

@santam85 santam85 commented Apr 12, 2019

Fixes #809 - circular references in JSON schemas are now possible.
Prerequisite was to fix zaggino/z-schema#199, we made a PR to z-schema and then prepared this.

@KonstantinSviridov @ddenisenko @postatum, we are using this library internally in our company and we need to use circular schemas really urgently, so we would appreciate if this PR could be merged and released ASAP!

@santam85
Copy link
Contributor Author

santam85 commented Apr 12, 2019

Please note that z-schema is dropping support for node 6 starting from version 4.
Node LTS support for v6 ends in April 2019, and we noticed the library has some issues already when testing on v6 with the version present on master, so we suggest bumping the version to a new major for this release to reflect the dropped support for v6, and updating the travis pipeline accordingly!

@sorohan
Copy link

sorohan commented Apr 12, 2019

Actually, it looks like the pipeline is failing for node 6 on master branch too. The fix in z-schema 4.0.1 should be compatible with v6.

@postatum postatum merged commit 07812c9 into raml-org:master Apr 13, 2019
@postatum
Copy link
Contributor

@santam85 thank you for the PR!

New version is released https://www.npmjs.com/package/raml-1-parser/v/1.1.52

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular references between two (or more) chemas cause a dead loop Circular JSON schema files
3 participants