forked from ArcadeData/arcadedb
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Df 269 add df classification validation #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly removed sources check.
…ts documents that are df-classification compliant from being filtered out.
Converted this to a draft so I can resolve conflicts. Dev has new keycloak attributes changes. |
patstevens4
reviewed
Aug 2, 2024
patstevens4
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added df-classification support. Changes needed to be made in a few unexpected places, namely the
OpaClient
and theArgument
class in order to support classification structure used by df-classification.More likely than not, more work needs to be done to fully support df-classification classifications, but this will be handled in a separate PR.
I removed any methods that IntelliJ highlighted as "safe delete," meaning they weren't being used for the sake of readability. I also removed commented out code blocks for the same reason.
Another major change is the classification validation no longer checks if a classification is supported by the deployment. This is handled by df-classification, which uses the cluster classification level defined in
.Values.global.classification
to determine if a classification is valid for the system.Related Issues
Part of DATAFABRIC-269
Test Procedure
df-269-add-df-classification-to-arcadedb
branch in data fabricdf-269-add-security-marking-validation
branch of df-classification & runmake kind
df-269-add-security-marking-validation
branch of df-arcadedb & runmake kind
df-arcadedb
pod to use thedev
tag forarcadedb
andclassification
containersclearance_usa
attribute toS
AND you'll have to update theCLASSIFICATION_LEVEL
on the df-classification pod toSECRET
. To do this, navigate to the raft-arcadedb deployment.yaml and replace the.Values.global.classification
withSECRET
. Once this is done, redeploy the pod usingdfdev cluster deploy -x raft-arcadedb
.