PG Client Hotfix #3203

elipe17 · 2024-09-26T16:28:11Z

Summary of Changes

Update base linux image

How to Test

List the steps to test the PR
These steps are generic, please adjust as necessary.

cd tdrs-frontend && docker-compose up
cd tdrs-backend && docker-compose up --build

Make sure the container builds and starts

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

[insert ACs here]
lfrohlich and/or adpennington confirmed that ACs are met.

Deliverable 2: Tested Code

Are all areas of code introduced in this PR meaningfully tested?
- If this PR introduces backend code changes, are they meaningfully tested?
- If this PR introduces frontend code changes, are they meaningfully tested?
Are code coverage minimums met?
- Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
- Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

Are backend code style checks passing on CircleCI?
Are frontend code style checks passing on CircleCI?
Are code maintainability principles being followed?

Deliverable 4: Accessible

Does this PR complete the epic?
Are links included to any other gov-approved PRs associated with epic?
Does PR include documentation for Raft's a11y review?
Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

Does this PR provide background for why coding decisions were made?
If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
If this PR introduces dependencies, are their licenses documented?
Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

Does the OWASP Scan pass on CircleCI?
Do manual code review and manual testing detect any new security issues?
If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

the purpose of the research
methods used to conduct the research
who participated in the research
what was tested and how
impact of research on TDP
(if applicable) final design mockups produced for TDP development

jtimpe

Container builds and starts, appears to work.

codecov · 2024-09-26T16:38:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.66%. Comparing base (b5d0aa8) to head (3933cec).
Report is 6 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3203      +/-   ##
===========================================
- Coverage    95.34%   92.66%   -2.68%     
===========================================
  Files           47       47              
  Lines         1009     1009              
  Branches       169      169              
===========================================
- Hits           962      935      -27     
- Misses          40       42       +2     
- Partials         7       32      +25

Flag	Coverage Δ
dev-frontend	`92.66% <ø> (-2.68%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5f110c...3933cec. Read the comment docs.

elipe17 · 2024-09-27T18:52:46Z

terraform/dev/main.tf

-  service_plan     = data.cloudfoundry_service.rds.service_plans["micro-psql"]
-  json_params      = "{\"version\": \"15\"}"
+  service_plan     = data.cloudfoundry_service.rds.service_plans["medium-gp-psql"]
+  json_params      = "{\"version\": \"15\", \"storage_type\": \"gp3\", \"storage\": 50}"


Added TF updates strictly to allow Alex to keep testing reparsing which requires the above service changes to function.

Will remove once we are ready to merge

raftmsohani · 2024-09-30T12:17:34Z

tdrs-backend/Dockerfile

@@ -17,7 +17,7 @@ RUN apt-get -y upgrade
 # Postgres client setup
 RUN apt --purge remove postgresql postgresql-* && apt install -y postgresql-common curl ca-certificates && install -d /usr/share/postgresql-common/pgdg && \
 curl -o /usr/share/postgresql-common/pgdg/apt.postgresql.org.asc --fail https://www.postgresql.org/media/keys/ACCC4CF8.asc && \
-sh -c 'echo "deb [signed-by=/usr/share/postgresql-common/pgdg/apt.postgresql.org.asc] https://apt.postgresql.org/pub/repos/apt $(lsb_release -cs)-pgdg main" > /etc/apt/sources.list.d/pgdg.list' && \
+sh -c 'echo "deb [signed-by=/usr/share/postgresql-common/pgdg/apt.postgresql.org.asc] https://apt.postgresql.org/pub/repos/apt bullseye-pgdg main" > /etc/apt/sources.list.d/pgdg.list' && \


nit: we will need to host this internally, they delete older un-supported versions

Andrew is working that in another ticket. This is just to get everybody's pipelines working again

andrew-jameson

System still working including nightly backup and reparsing both locally and when deployed to raft.

andrew-jameson · 2024-09-30T14:01:24Z

@elipe17 Please revert those Terraform changes and let's get this merged. UX requested a new release last week so would like to get to it this morning. And thank you for taking on this hotfix :)

- remove pg client from container

4fccc17

elipe17 self-assigned this Sep 26, 2024

elipe17 requested review from andrew-jameson, raftmsohani and jtimpe September 26, 2024 16:28

elipe17 added the hotfix label Sep 26, 2024

jtimpe approved these changes Sep 26, 2024

View reviewed changes

- Updated debian to bullseye to support supported postgres client

4a4ab19

elipe17 added the Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI label Sep 27, 2024

- update tf for deploy

dec3627

elipe17 added Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI and removed Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI labels Sep 27, 2024

elipe17 commented Sep 27, 2024

View reviewed changes

raftmsohani reviewed Sep 30, 2024

View reviewed changes

raftmsohani approved these changes Sep 30, 2024

View reviewed changes

elipe17 mentioned this pull request Sep 30, 2024

Reparse Memory Management #3172

Merged

27 tasks

andrew-jameson approved these changes Sep 30, 2024

View reviewed changes

andrew-jameson added the Ready to Merge label Sep 30, 2024

- revert TF

3933cec

elipe17 merged commit bf4fd11 into develop Sep 30, 2024
13 checks passed

elipe17 deleted the pg-client-hotfix branch September 30, 2024 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PG Client Hotfix #3203

PG Client Hotfix #3203

elipe17 commented Sep 26, 2024 •

edited

Loading

jtimpe left a comment

codecov bot commented Sep 26, 2024 •

edited

Loading

elipe17 Sep 27, 2024

elipe17 Sep 27, 2024

raftmsohani Sep 30, 2024

elipe17 Sep 30, 2024

andrew-jameson left a comment

andrew-jameson commented Sep 30, 2024

PG Client Hotfix #3203

PG Client Hotfix #3203

Conversation

elipe17 commented Sep 26, 2024 • edited Loading

Summary of Changes

How to Test

Deliverables

jtimpe left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 26, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrew-jameson left a comment

Choose a reason for hiding this comment

andrew-jameson commented Sep 30, 2024

elipe17 commented Sep 26, 2024 •

edited

Loading

codecov bot commented Sep 26, 2024 •

edited

Loading