-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLG Cloud.gov #3192
base: develop
Are you sure you want to change the base?
PLG Cloud.gov #3192
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3192 +/- ##
===========================================
- Coverage 92.66% 89.46% -3.21%
===========================================
Files 47 296 +249
Lines 1009 8655 +7646
Branches 169 819 +650
===========================================
+ Hits 935 7743 +6808
- Misses 42 791 +749
- Partials 32 121 +89
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 248 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
- update volume mount - update promtail to scrape new location - update backend log file location
- Remove docker container scrape config
- Testing running bogus command for nginx
popd | ||
} | ||
|
||
update_plg_networking() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want PLG to live in prod? If so, need to update networking.
- add retention for prometheus - change promtail log level
- Add TODOs for future work
So that we all don't have to deploy to test this, could you possibly post screen shots from running command in steps (only for changes to deploy command)? |
Summary of Changes
Pull request closes #3046
Considerations:
Need to verify logs in Loki are queryable from days, weeks, months, etc agoHow to Test
PLG is deployed in the dev environment for the moment. If you would like to browse Grafana I have opened a public route to it for the interim until we decide where PLG is going to live. Reach out to me for username and password. Once you're logged in, feel free to browse the dashboards. Note, the
Logs
dashboard only has logging information as far back as 09/25/2024 at ~9:40am ET since that is when promtail had it's first successful exports.Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):