-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(draw): narrow return type for empty and non-empty arrays (take II) #153
Open
crishoj
wants to merge
11
commits into
radashi-org:main
Choose a base branch
from
crishoj:narrow-return-type-for-draw
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
aleclarson
reviewed
Aug 6, 2024
aleclarson
reviewed
Aug 6, 2024
aleclarson
reviewed
Aug 6, 2024
Good job @crishoj, now we don't have that false positive. |
Co-authored-by: Alec Larson <[email protected]>
1 task
MarlonPassos-git
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting that line is all ok
Co-authored-by: Marlon Passos <[email protected]>
Benchmark Results
Generally speaking, any regression ≥20% should be investigated if it wasn't to be expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a renewed attempt at narrowing the return type for
draw()
, so that emptiness of the array argument is taken into account.T
ornull
.T|null
.T|null
for empty arrays (not sure why)T
for non-empty arrays.Disclosure: I am a Typescript novice and welcome your feedback.
If the approach is sound, similar overrides could be considered for
first
last
Related issue, if any:
For any code change,
Does this PR introduce a breaking change?
No
Bundle impact
src/random/draw.ts
Footnotes
Function size includes the
import
dependencies of the function. ↩